bpo-35240: Travis CI runs doctest without XVFB_RUN#10752
Closed
vstinner wants to merge 1 commit intopython:masterfrom
vstinner:doctest
Closed
bpo-35240: Travis CI runs doctest without XVFB_RUN#10752vstinner wants to merge 1 commit intopython:masterfrom vstinner:doctest
vstinner wants to merge 1 commit intopython:masterfrom
vstinner:doctest
Conversation
Member
Author
|
I don't see the point of running "make doctest" with xvfb-run. I guess that it was copied/pasted when "make doctest" has been added to Travis CI by @matrixise in .travis.yml: commit 859c068. To run the Python test suite, xvfb-run makes sense since multiple tests run a GUI. |
Member
Author
|
Oh, doctest failed on Travis CI :-( |
Member
|
The current But this can be gracefully muted, like we're currently disabling those same tests when we can't import tkinter, in Docs/config.py check for: |
Member
Author
|
I was wrong. PR #10753 seems to be a better option. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue35240