Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33029: Fix more invalid function cast warnings with gcc 8. #10746

Merged
merged 1 commit into from
Nov 27, 2018
Merged

bpo-33029: Fix more invalid function cast warnings with gcc 8. #10746

merged 1 commit into from
Nov 27, 2018

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Nov 27, 2018 •
edited by bedevere-bot
Loading

Fix signatures of getter and setter functions. Fix return type
for few other functions.

https://bugs.python.org/issue33029

@serhiy-storchaka
bpo-33029: Fix more invalid function cast warnings with gcc 8.
47eecc3 
Fix signatures of getter and setter functions. Fix return type
for few other functions.
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.6 skip news labels Nov 27, 2018
@serhiy-storchaka serhiy-storchaka mentioned this pull request Nov 27, 2018
Closed
@serhiy-storchaka serhiy-storchaka merged commit d4f9cf5 into python:master Nov 27, 2018
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the getter-setter-func-casts branch November 27, 2018 17:34
@bedevere-bot
Copy link

GH-10747 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 27, 2018
@serhiy-storchaka @miss-islington
bpo-33029: Fix signatures of getter and setter functions. (pythonGH-1…
483de83 
…0746)

Fix also return type for few other functions (clear, releasebuffer).
(cherry picked from commit d4f9cf5)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d4f9cf5545d6d8844e0726552ef2e366f5cc3abd 3.6

@bedevere-bot
Copy link

GH-10749 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request Nov 27, 2018
@miss-islington @serhiy-storchaka
bpo-33029: Fix signatures of getter and setter functions. (GH-10746)
5ceb701 
Fix also return type for few other functions (clear, releasebuffer).
(cherry picked from commit d4f9cf5)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Nov 27, 2018
@serhiy-storchaka
[3.6] bpo-33029: Fix signatures of getter and setter functions. (pyth…
a76cd04 
…onGH-10746)

Fix also return type for few other functions (clear, releasebuffer).
(cherry picked from commit d4f9cf5)
serhiy-storchaka added a commit that referenced this pull request Nov 27, 2018
@serhiy-storchaka
[3.6] bpo-33029: Fix signatures of getter and setter functions. (GH-1…
29d2f3c 
…0746) (GH-10749)

Fix also return type for few other functions (clear, releasebuffer).
(cherry picked from commit d4f9cf5)
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 Awaiting requested review from 1st1

@asvetlov asvetlov Awaiting requested review from asvetlov

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees
No one assigned
Labels
skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @miss-islington @bedevere-bot @the-knights-who-say-ni