Skip to content

gh-104050: Argument Clinic: Annotate CRenderData.__init__ #107207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions Tools/clinic/clinic.py
Original file line number Diff line number Diff line change
Expand Up @@ -372,36 +372,36 @@ def version_comparitor(version1: str, version2: str) -> Literal[-1, 0, 1]:


class CRenderData:
def __init__(self):
def __init__(self) -> None:

# The C statements to declare variables.
# Should be full lines with \n eol characters.
self.declarations = []
self.declarations: list[str] = []

# The C statements required to initialize the variables before the parse call.
# Should be full lines with \n eol characters.
self.initializers = []
self.initializers: list[str] = []

# The C statements needed to dynamically modify the values
# parsed by the parse call, before calling the impl.
self.modifications = []
self.modifications: list[str] = []

# The entries for the "keywords" array for PyArg_ParseTuple.
# Should be individual strings representing the names.
self.keywords = []
self.keywords: list[str] = []

# The "format units" for PyArg_ParseTuple.
# Should be individual strings that will get
self.format_units = []
self.format_units: list[str] = []

# The varargs arguments for PyArg_ParseTuple.
self.parse_arguments = []
self.parse_arguments: list[str] = []

# The parameter declarations for the impl function.
self.impl_parameters = []
self.impl_parameters: list[str] = []

# The arguments to the impl function at the time it's called.
self.impl_arguments = []
self.impl_arguments: list[str] = []

# For return converters: the name of the variable that
# should receive the value returned by the impl.
Expand All @@ -411,17 +411,17 @@ def __init__(self):
# value from the parse function. This is also where
# you should check the _return_value for errors, and
# "goto exit" if there are any.
self.return_conversion = []
self.return_conversion: list[str] = []
self.converter_retval = "_return_value"

# The C statements required to do some operations
# after the end of parsing but before cleaning up.
# These operations may be, for example, memory deallocations which
# can only be done without any error happening during argument parsing.
self.post_parsing = []
self.post_parsing: list[str] = []

# The C statements required to clean up after the impl call.
self.cleanup = []
self.cleanup: list[str] = []


class FormatCounterFormatter(string.Formatter):
Expand Down