gh-104469 Convert_testcapi/vectorcall.c to use AC#106557
gh-104469 Convert_testcapi/vectorcall.c to use AC#106557corona10 merged 6 commits intopython:mainfrom
Conversation
littlebutt
commented
Jul 9, 2023
littlebutt
commented
- issue: Improve the readability and maintainability of test_capi using the AC #104469
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
All commit authors signed the Contributor License Agreement. |
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
I don't think that we need to convert test_ prefixed functions. They are executed as tests directly.
Well, I am okay with it. We already did. |
corona10
left a comment
corona10
left a comment
There was a problem hiding this comment.
First thing, method names are wrong.
Please change method names and then executing the make clinic
Modules/_testcapi/vectorcall.c
Outdated
| } | ||
|
|
||
| /*[clinic input] | ||
| _testcapi.test_pyobject_fastcalldict |
There was a problem hiding this comment.
| _testcapi.test_pyobject_fastcalldict | |
| _testcapi.pyobject_fastcalldict |
Modules/_testcapi/vectorcall.c
Outdated
| } | ||
|
|
||
| /*[clinic input] | ||
| _testcapi.test_pyobject_vectorcall |
There was a problem hiding this comment.
| _testcapi.test_pyobject_vectorcall | |
| _testcapi.pyvectorcall_call |
Modules/_testcapi/vectorcall.c
Outdated
| _testcapi.test_pyobject_vectorcall | ||
| func: object | ||
| func_args: object | ||
| kwnames: object = NULL |
There was a problem hiding this comment.
| kwnames: object = NULL | |
| kwnames: object = None |
Modules/_testcapi/vectorcall.c
Outdated
| } | ||
|
|
||
| /*[clinic input] | ||
| _testcapi.test_pyvectorcall_call |
There was a problem hiding this comment.
| _testcapi.test_pyvectorcall_call | |
| _testcapi.pyvectorcall_call |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
@corona10 Thank you for your suggestions and I fixed these method names. But the complaints still exist because of missing arguments in test cases. |
According to CI, it looks not, did you rebuild the code? |
No, I didn't. I just ran |
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
4 participants
