bpo-20504 : in cgi.py, fix bug when a multipart/form-data request has… #10638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… no content-length header
Lib/test/test_cgi.py
Outdated
| } | ||
| fields = cgi.FieldStorage(fp, environ=env) | ||
|
|
||
| assert len(fields["my-arg"].file.read()) == 5 |
There was a problem hiding this comment.
unittest.TestCase methods (like assertEqual()) should be used instead of raw asserts.
There was a problem hiding this comment.
Thanks, done in commit d67919b
|
@benjaminp: Please replace |
|
Thanks @PierreQuentel for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 11, 2019
pythonGH-10638) * bpo-20504 : in cgi.py, fix bug when a multipart/form-data request has no content-length header * Add Misc/NEWS.d/next file. * Add rst formatting for NEWS.d/next file * Reaplce assert by self.assertEqual (cherry picked from commit 2d7caca) Co-authored-by: Pierre Quentel <pierre.quentel@gmail.com>
|
GH-15919 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 11, 2019
pythonGH-10638) * bpo-20504 : in cgi.py, fix bug when a multipart/form-data request has no content-length header * Add Misc/NEWS.d/next file. * Add rst formatting for NEWS.d/next file * Reaplce assert by self.assertEqual (cherry picked from commit 2d7caca) Co-authored-by: Pierre Quentel <pierre.quentel@gmail.com>
|
GH-15920 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Sep 11, 2019
GH-10638) * bpo-20504 : in cgi.py, fix bug when a multipart/form-data request has no content-length header * Add Misc/NEWS.d/next file. * Add rst formatting for NEWS.d/next file * Reaplce assert by self.assertEqual (cherry picked from commit 2d7caca) Co-authored-by: Pierre Quentel <pierre.quentel@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Sep 11, 2019
GH-10638) * bpo-20504 : in cgi.py, fix bug when a multipart/form-data request has no content-length header * Add Misc/NEWS.d/next file. * Add rst formatting for NEWS.d/next file * Reaplce assert by self.assertEqual (cherry picked from commit 2d7caca) Co-authored-by: Pierre Quentel <pierre.quentel@gmail.com>
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Sep 12, 2019
python#10638) * bpo-20504 : in cgi.py, fix bug when a multipart/form-data request has no content-length header * Add Misc/NEWS.d/next file. * Add rst formatting for NEWS.d/next file * Reaplce assert by self.assertEqual
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
python#10638) * bpo-20504 : in cgi.py, fix bug when a multipart/form-data request has no content-length header * Add Misc/NEWS.d/next file. * Add rst formatting for NEWS.d/next file * Reaplce assert by self.assertEqual
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… no content-length header
https://bugs.python.org/issue20504