gh-106194: Rename duplicated tests in test_curses#106196
Merged
hugovk merged 3 commits intopython:mainfrom Jun 28, 2023
Merged
Conversation
hugovk
reviewed
Jun 28, 2023
Contributor
Contributor
|
Sorry, @sobolevn and @hugovk, I could not cleanly backport this to |
|
GH-106216 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 28, 2023
hugovk
pushed a commit
that referenced
this pull request
Jun 28, 2023
#106216) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Member
|
These tests were added in this bug fix: #103783, which didn't get backported to 3.11 for some reason. I'll ask over there if it should be back backported, and if so, this test fix should be included. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on tests near the problematic ones, we can see
test_move_upandtest_move_down.Source:
cpython/Lib/test/test_curses.py
Lines 1378 to 1390 in bbf722d
So, I think it is safe to just replace them with
test_move_leftandtest_move_right.test_curseshas duplicated tests #106194