gh-105622: Parse HTTP headers with default email policy#105918
Closed
michaelfm1211 wants to merge 3 commits into
Closed
gh-105622: Parse HTTP headers with default email policy#105918michaelfm1211 wants to merge 3 commits into
michaelfm1211 wants to merge 3 commits into
Conversation
Updates http.client._parse_header_lines to use email.policy.default when parsing HTTP headers. An email policy should always be specified and allows the http module to use email's header registry.
Member
|
@vstinner, probably? |
|
The following commit authors need to sign the Contributor License Agreement: |
vstinner
reviewed
Apr 18, 2025
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
Can you add some examples of headers previously accepted and no longer accepted by the new policy? Add them to tests.
| self.fail('Date value not in %r format' % dateformat) | ||
| date = fileheaders.get('Date') | ||
| self.assertIsInstance(date, email.headerregistry.DateHeader, | ||
| "Date is not an instance of email.headerregistery.DateHeader") |
Member
There was a problem hiding this comment.
I don't think that the 3rd argument is needed.
Member
|
Is this change backward incompatible? |
|
This PR is stale because it has been open for 30 days with no activity. |
Member
|
The CLA was not signed and my review from last year was not addressed. I close the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
http.client._parse_header_linesto useemail.policy.defaultwhen parsing HTTP headers. An email policy should always be specified and allows the http module to use email's header registry.http.clientto use http email policy for parsing #105622📚 Documentation preview 📚: https://cpython-previews--105918.org.readthedocs.build/