Skip to content

gh-105375: Improve error handling in compiler_enter_scope() #105494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2023
Merged

gh-105375: Improve error handling in compiler_enter_scope() #105494

merged 1 commit into from
Jun 9, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jun 8, 2023 •
edited by bedevere-bot
Loading

@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jun 8, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 8, 2023
Closed
18 tasks
@erlend-aasland erlend-aasland merged commit 6c832dd into python:main Jun 9, 2023
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the improve-compiler-error-handling branch June 9, 2023 16:55
@miss-islington
Copy link
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6c832ddcf28187f86100c790afb16a0223d945d0 3.11

@bedevere-bot
Copy link

GH-105581 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 9, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 9, 2023
@erlend-aasland @miss-islington
pythongh-105375: Improve error handling in compiler_enter_scope() (py…
fefe308 
…thonGH-105494)

(cherry picked from commit 6c832dd)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

GH-105582 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 9, 2023
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jun 9, 2023
@erlend-aasland
[3.11] pythongh-105375: Improve error handling in compiler_enter_scop…
73d4a26 
…e() (python#105494)
@erlend-aasland
Copy link
Contributor Author

Thanks for the review, Carl!

erlend-aasland added a commit that referenced this pull request Jun 9, 2023
@miss-islington @erlend-aasland
[3.12] gh-105375: Improve error handling in compiler_enter_scope() (G…
6540493 
…H-105494) (#105581)

(cherry picked from commit 6c832dd)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit that referenced this pull request Jun 9, 2023
@erlend-aasland
[3.11] gh-105375: Improve error handling in compiler_enter_scope() (#…
90e357b 
…105494) (#105582)

(cherry picked from commit 6c832dd)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@erlend-aasland erlend-aasland linked an issue Jun 9, 2023 that may be closed by this pull request
Incorrect error handling for APIs that can raise exceptions #105375
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carljm carljm carljm approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Assignees

@erlend-aasland erlend-aasland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect error handling for APIs that can raise exceptions
4 participants
@erlend-aasland @miss-islington @bedevere-bot @carljm