-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-75552: Remove deprecated tkinter.tix module #104902
Conversation
72026c5
to
e7abc51
Compare
If you haven't rebuilt the MSI yourself, might be worth touching something in the tools/msi directory so that the PR tests run. I don't think there are any Tix-specific dependencies in it though, so it ought to be fine. |
Ah, hmm. Because of the way Tcl/Tk/Tix is packaged in |
e7abc51
to
0524a21
Compare
I suppose at worst the Interestingly, the |
Yeah, there'll be updates needed to https://github.com/python/release-tools/blob/master/windows-release/tcltk-build.yml, which is where the "real" build happens. I can do that. We probably need to tag builds separately for "without Tix" unless we've got a major version update coming (i.e. one that won't be used for 3.12)? |
The warnings are all expected... the errors are because we don't build the docs first in that job. I've just filed #104929 to fix that, so if you want to wait and merge it before merging this, that ought to give you clean results? |
Nice branch name! :) Can some of this stuff be removed?
|
See also python/release-tools#47 where I'm making the Tix build step optional for the cpython-bin-deps build. The package from my test run is at https://dev.azure.com/Python/cpython/_build/results?buildId=128771&view=artifacts&pathAsName=false&type=publishedArtifacts (for about 30 days I expect) if you want to check that it works. You shouldn't need to log in, but all you can do is click the three dots at the right of the |
I opted to keep the The mentions in |
There still is no alternative for the tix module. The Select and Balloon classes are nowhere to be found, no Python replacement, and ttk doesn't even look like tix. What are the poor users to do? |
Tix has been unmaintained for 10 years now, has open security vulnerabilities, and every update of anything in our toolchain risks breaking it. If you still need it, it's open source and can be vendored into your project or maintained separately, but we will no longer provide it out of the box as of Python 3.13. |
c8d477d
to
99efec0
Compare
Mostly this is an excuse to run the MSI CI tests.
99efec0
to
27c8d16
Compare
📚 Documentation preview 📚: https://cpython-previews--104902.org.readthedocs.build/