typing docs: Move some classes out of the "Generics" section #104707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- AnyStr can be used in type annotations, contrary to the section header - Unpack can also be used in annotations, and its use is not restricted to generics. It makes more sense with other building blocks like Required. - Protocol is not necessarily generic. Also fix the indentation for two notes associated with Concatenate. Split off from python#104642, but I think this change is independently an improvement.
JelleZijlstra
requested review from
gvanrossum,
Fidget-Spinner and
AlexWaygood
as code owners
bedevere-bot
added
awaiting core review
docs
|
(Note these were all in a section that starts with "These are not used in annotations. They are building blocks for creating generic types.") |
|
@AlexWaygood could you review this one so it doesn't accumulate merge conflicts? Thanks! |
AlexWaygood
approved these changes
May 21, 2023
|
Should we backport this to 3.11? The changes are an improvement on their own, I think, and backporting could help reduce the risk of future merge conflicts. |
|
Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Sorry, @JelleZijlstra, I could not cleanly backport this to |
|
GH-104721 is a backport of this pull request to the 3.11 branch. |
JelleZijlstra
added a commit
to JelleZijlstra/cpython
that referenced
this pull request
May 21, 2023
…ythonGH-104707) - AnyStr can be used in type annotations, contrary to the section header - Unpack can also be used in annotations, and its use is not restricted to generics. It makes more sense with other building blocks like Required. - Protocol is not necessarily generic. Also fix the indentation for two notes associated with Concatenate. Split off from pythonGH-104642, but I think this change is independently an improvement.. (cherry picked from commit ab71acd) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
AlexWaygood
added a commit
that referenced
this pull request
May 21, 2023
…H-104707) (#104721) - AnyStr can be used in type annotations, contrary to the section header - Unpack can also be used in annotations, and its use is not restricted to generics. It makes more sense with other building blocks like Required. - Protocol is not necessarily generic. Also fix the indentation for two notes associated with Concatenate. (cherry picked from commit ab71acd) --------- Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to generics. It makes more sense with other building blocks like Required.
Also fix the indentation for two notes associated with Concatenate.
Split off from #104642, but I think this change is independently an
improvement.
📚 Documentation preview 📚: https://cpython-previews--104707.org.readthedocs.build/