GH-102613: Fix recursion error from pathlib.Path.glob()#104373
GH-102613: Fix recursion error from pathlib.Path.glob()#104373barneygale merged 1 commit intopython:mainfrom
pathlib.Path.glob()#104373Conversation
Use `Path.walk()` to implement the recursive wildcard `**`. This method uses an iterative (rather than recursive) walk - see pythonGH-100282.
|
This won't backport to 3.11, as |
|
@Ovsyanka83 would you like to review, if you have a mo? Uses your shiny |
|
Will take a look on saturday! :) |
There was a problem hiding this comment.
Thanks for using our work here! Every time "walk" gets used or mentioned, it makes me feel really nice and like my work has made a difference :D
I like the ideas and have a few suggestions here and there -- your logic feels quite right and my changes are doubtful and mostly stylistic :)
zmievsa
left a comment
zmievsa
left a comment
There was a problem hiding this comment.
After your replies the logic itself makes much more sense so I'm ready to approve this.
|
Thank you! |
carljm
left a comment
carljm
left a comment
There was a problem hiding this comment.
This looks good to me, apart from the one inline comment, which could be addressed as a follow-up also.
* main: pythonGH-104510: Fix refleaks in `_io` base types (python#104516) pythongh-104539: Fix indentation error in logging.config.rst (python#104545) pythongh-104050: Don't star-import 'types' in Argument Clinic (python#104543) pythongh-104050: Add basic typing to CConverter in clinic.py (python#104538) pythongh-64595: Fix write file logic in Argument Clinic (python#104507) pythongh-104523: Inline minimal PGO rules (python#104524) pythongh-103861: Fix Zip64 extensions not being properly applied in some cases (python#103863) pythongh-69152: add method get_proxy_response_headers to HTTPConnection class (python#104248) pythongh-103763: Implement PEP 695 (python#103764) pythongh-104461: Run tkinter test_configure_screen on X11 only (pythonGH-104462) pythongh-104469: Convert _testcapi/watchers.c to use Argument Clinic (python#104503) pythongh-104482: Fix error handling bugs in ast.c (python#104483) pythongh-104341: Adjust tstate_must_exit() to Respect Interpreter Finalization (pythongh-104437) pythonGH-102613: Fix recursion error from `pathlib.Path.glob()` (pythonGH-104373)
5 participants
Use
Path.walk()to implement the recursive wildcard**. This method uses an iterative (rather than recursive) walk - see GH-100282.