-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
GH-100479: Fix pathlib test failure on WASI #104215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+2
−1
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, I know very little about this module or how the tests are usually done. That said, it looks like all the other uses of
is_wasi
in this file relate to skipping the whole test, rather than a part of it. Personally, I have no relevant opinion on if your change is okay. 😄 (My irrelevant opinion is that, generally, the behavior of a test should not change based on some environmental condition.)(Also, FYI, I pointed out the failing buildbot earlier because the first failure happened when a change of mine was merged. That's when I noticed it was probably the pathlib change. Otherwise I don't have any particular interest and probably would not have noticed. 😄)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Eric -- if it's just a specific part of this test that fails on WASI, best to separate it out into a separate test method that's decorated with
@skipIf(is_wasi, "WASI has no user accounts")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree in principle, but this style of tweaking test behaviour slightly based on what the system supports is pervasive throughout
test_pathlib.py
. For example, a few lines below we have:Is there something to be said for using a consistent approach, even if it's imperfect?
(I don't feel strongly about this, just thought I'd point it out!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. I don't like it, and I'd love to see a PR cleaning all those up ;)
But I guess consistency wins the day for now!