Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-99113: Add a check for Py_MOD_PER_INTERPRETER_GIL_SUPPORTED #104206

Merged
merged 9 commits into from
May 6, 2023
Merged

gh-99113: Add a check for Py_MOD_PER_INTERPRETER_GIL_SUPPORTED #104206

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a73f36f
Add _PyInterpreterConfig.own_gil.
ericsnowcurrently Nov 3, 2022
37bf29c
Use PyInterpreterConfig.own_gil.
ericsnowcurrently Nov 4, 2022
e32c487
Fail unsupported extensions.
ericsnowcurrently May 5, 2023
51d8587
Add a test.
ericsnowcurrently May 5, 2023
e2ddc27
Add a NEWS entry.
ericsnowcurrently May 5, 2023
fee34e0
Merge branch 'main' into own-gil-extension-check
ericsnowcurrently May 5, 2023
ac95d09
Add a note.
ericsnowcurrently May 6, 2023
5ccc220
Add a test for when an extension has multiple Py_mod_create slots.
ericsnowcurrently May 6, 2023
376217a
Add a test for when an extension has multiple Py_mod_multiple_interpr…
ericsnowcurrently May 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a NEWS entry.
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed May 5, 2023
commit e2ddc272382d274c9a4b9bdcc2355073da049591
11 changes: 11 additions & 0 deletions Misc/NEWS.d/next/Core and Builtins/2023-05-05-13-18-56.gh-issue-99113.hT1ajK.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
Multi-phase init extension modules may now indicate that they support
running in subinterpreters that have their own GIL. This is done by using
``Py_MOD_PER_INTERPRETER_GIL_SUPPORTED`` as the value for the
``Py_mod_multiple_interpreters`` module def slot. Otherwise the module, by
default, cannot be imported in such subinterpreters. (This does not affect
the main interpreter or subinterpreters that do not have their own GIL.) In
addition to the isolation that multi-phase init already normally requires,
support for per-interpreter GIL involves one additional constraint:
thread-safety. If the module has external (linked) dependencies and those
libraries have any state that isn't thread-safe then the module must do the
additional work to add thread-safety. This should be an uncommon case.