-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-35015: Doc: Fix internationalisation of the availability directive. #10360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ece22d2
to
f4a34aa
Compare
Diff is nice:
|
Thanks @JulienPalard for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
GH-10399 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 7, 2018
…e. (pythonGH-10360) (cherry picked from commit beed84c) Co-authored-by: Julien Palard <julien@palard.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't really understand why we have to give the content twice (once as a parameter of the node, and once as child of the node) but that's what's the
BaseAdmonition
directive does:Add it first as a text parameter of the node:
then add the content as child of the node:
self.state.nested_parse(self.content, self.content_offset,
admonition_node)
so I did the same and it works.
https://bugs.python.org/issue35015
https://bugs.python.org/issue35015