Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-35015: Doc: Fix internationalisation of the availability directive. #10360

Merged
merged 3 commits into from
Nov 7, 2018

Conversation

JulienPalard
Copy link
Member

@JulienPalard JulienPalard commented Nov 6, 2018

I don't really understand why we have to give the content twice (once as a parameter of the node, and once as child of the node) but that's what's the BaseAdmonition directive does:

Add it first as a text parameter of the node:

admonition_node = self.node_class(text, **self.options)

then add the content as child of the node:
self.state.nested_parse(self.content, self.content_offset,
admonition_node)

so I did the same and it works.

https://bugs.python.org/issue35015

https://bugs.python.org/issue35015

@JulienPalard
Copy link
Member Author

DO-NOT-MERGE tag while I'm running a diff of generated pot files.

@JulienPalard
Copy link
Member Author

Diff is nice:

< msgid "Availability: Unix, Windows.  spawnlp(), spawnlpe(), spawnvp() and spawnvpe() are not available on Windows.  spawnle() and spawnve() are n
ot thread-safe on Windows; we advise you to use the subprocess module instead."
---
> msgid ":ref:`Availability <availability>`: Unix, Windows.  :func:`spawnlp`, :func:`spawnlpe`, :func:`spawnvp` and :func:`spawnvpe` are not availa
ble on Windows.  :func:`spawnle` and :func:`spawnve` are not thread-safe on Windows; we advise you to use the :mod:`subprocess` module instead."

@JulienPalard JulienPalard merged commit beed84c into python:master Nov 7, 2018
@miss-islington
Copy link
Contributor

Thanks @JulienPalard for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@JulienPalard JulienPalard deleted the fix-i18n-availabilit branch November 7, 2018 21:42
@bedevere-bot
Copy link

GH-10399 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 7, 2018
…e. (pythonGH-10360)

(cherry picked from commit beed84c)

Co-authored-by: Julien Palard <julien@palard.fr>
miss-islington added a commit that referenced this pull request Nov 7, 2018
…e. (GH-10360)

(cherry picked from commit beed84c)

Co-authored-by: Julien Palard <julien@palard.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants