GH-83893: Cross reference env. vars and -X command line options#103414
Merged
miss-islington merged 9 commits intopython:mainfrom Apr 12, 2023
Merged
GH-83893: Cross reference env. vars and -X command line options#103414miss-islington merged 9 commits intopython:mainfrom
miss-islington merged 9 commits intopython:mainfrom
Conversation
CAM-Gerlach
reviewed
Apr 11, 2023
Member
There was a problem hiding this comment.
Standard reminder: You can directly apply all the suggestions you want in one go by going to Files changed -> Clicking Add to batch on each suggestion -> When done, clicking Commit
One suggestion, aside from those @erlend-aasland already made.
Just to note, the docs build error is unrelated and will be fixed by #103421
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
CAM-Gerlach
approved these changes
Apr 12, 2023
Member
CAM-Gerlach
left a comment
CAM-Gerlach
left a comment
There was a problem hiding this comment.
LGTM from me; thanks @furkanonder
Contributor
erlend-aasland
left a comment
erlend-aasland
left a comment
There was a problem hiding this comment.
LGTM, and thanks for picking this up, Furkan!
erlend-aasland
approved these changes
Apr 12, 2023
Contributor
|
Status check is done, and it's a success ✅. |
Contributor
|
Thanks @furkanonder for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 12, 2023
…pythonGH-103414) (cherry picked from commit d65ed69) Co-authored-by: Furkan Onder <furkanonder@protonmail.com> Co-authored-by: Erlend E. Aasland
|
GH-103467 is a backport of this pull request to the 3.11 branch. |
miss-islington
added a commit
that referenced
this pull request
Apr 16, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Apr 18, 2023
…pythonGH-103414) Co-authored-by: Erlend E. Aasland
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-X devoption should mention PYTHONDEVMODE #83893Co-authored-by: Erlend E. Aasland