Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-103373: __mro_entries__ docs: improve cross references #103398

Merged
merged 3 commits into from
Apr 11, 2023
Merged

gh-103373: __mro_entries__ docs: improve cross references #103398

merged 3 commits into from
Apr 11, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Apr 9, 2023 •
edited
Loading

@AlexWaygood AlexWaygood added the needs backport to 3.11 only security fixes label Apr 9, 2023
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Apr 9, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 9, 2023
Closed
@AlexWaygood
Copy link
Member Author

AlexWaygood commented Apr 9, 2023 •
edited
Loading

Docs preview links:

CAM-Gerlach
CAM-Gerlach reviewed Apr 11, 2023
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two tiny nits, otherwise LGTM, thanks!

AlexWaygood
AlexWaygood commented Apr 11, 2023
View reviewed changes
AlexWaygood and others added 2 commits April 11, 2023 09:05
@AlexWaygood @CAM-Gerlach
Apply suggestions from code review
e386bfb 
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@AlexWaygood
Merge branch 'main' into mro-docs-2
93e1fbb
@AlexWaygood AlexWaygood merged commit e071f00 into python:main Apr 11, 2023
@miss-islington
Copy link
Contributor

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@AlexWaygood AlexWaygood deleted the mro-docs-2 branch April 11, 2023 10:25
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 11, 2023
@AlexWaygood @CAM-Gerlach @miss-islington
pythongh-103373: __mro_entries__ docs: improve cross references (py…
526b8b7 
…thonGH-103398)

(cherry picked from commit e071f00)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@bedevere-bot
Copy link

GH-103440 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Apr 11, 2023
@AlexWaygood
Copy link
Member Author

Thanks @CAM-Gerlach!

miss-islington added a commit that referenced this pull request Apr 11, 2023
@miss-islington @AlexWaygood @CAM-Gerlach
gh-103373: __mro_entries__ docs: improve cross references (GH-103398)
07a2851 
(cherry picked from commit e071f00)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@AlexWaygood @CAM-Gerlach @warsaw
pythongh-103373: __mro_entries__ docs: improve cross references (py…
a5855f7 
…thon#103398)

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@AlexWaygood AlexWaygood mentioned this pull request Apr 12, 2023
Merged
aisk pushed a commit to aisk/cpython that referenced this pull request Apr 18, 2023
@AlexWaygood @CAM-Gerlach @aisk
pythongh-103373: __mro_entries__ docs: improve cross references (py…
873b53d 
…thon#103398)

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach left review comments

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexWaygood @miss-islington @bedevere-bot @CAM-Gerlach