bpo-35161: Fix stack-use-after-scope in grp.getgr{nam,gid} and pwd.getpw{nam,uid} #10319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tpw{nam,uid}
Reported by ASAN.
serhiy-storchaka
changed the title
| @@ -124,11 +124,11 @@ grp_getgrgid_impl(PyObject *module, PyObject *id) | |||
| Py_DECREF(py_int_id); | |||
| } | |||
| #ifdef HAVE_GETGRGID_R | |||
| Py_BEGIN_ALLOW_THREADS | |||
| int status; | |||
| Py_ssize_t bufsize; | |||
| struct group grp; | |||
There was a problem hiding this comment.
Could you please add a comment about grp is used via the p pointer.
There was a problem hiding this comment.
I've added comments.
serhiy-storchaka
approved these changes
Nov 4, 2018
serhiy-storchaka
added
type-bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by ASAN.
https://bugs.python.org/issue35161