gh-103171: Document and test behaviour change in 3.11 for runtime-checkable protocols decorated with @final#103173
Closed
AlexWaygood wants to merge 2 commits intopython:mainfrom
Closed
Conversation
…ble protocols decorated with `@final`
AlexWaygood
requested review from
Fidget-Spinner,
JelleZijlstra and
gvanrossum
as code owners
AlexWaygood
changed the title
@final@final
Member
Author
|
Marking as DO-NOT-MERGE until discussion on the issue has finished: #103171 (comment) |
JelleZijlstra
requested changes
Jun 7, 2023
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
I'd like to instead change the behavior, see the issue.
(Also I want this to go out of my review requested list.)
|
When you're done making the requested changes, leave the comment: |
Member
Author
In that case I'll close this PR for now, since the better approach will probably be to fix the behavior in a PR to the 3.11 branch, and then "forward-port" the tests from that PR to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@finaland@runtime_checkablein 3.11 #103171