Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-60712: Include the "object" type in the lists of documented types #103036

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 23 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
2c09057
add test for the predefined object's attributes
furkanonder Mar 25, 2023
9a71e36
Include the "object" type in the lists of documented types
furkanonder Mar 25, 2023
d327409
remove 'or' from augment tuple
furkanonder Mar 28, 2023
73698a5
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 28, 2023
1064065
Add cross-reference to news
furkanonder Mar 30, 2023
ce4d192
Fix format for the function parameter
furkanonder Mar 30, 2023
aca2c04
Add space
furkanonder Mar 30, 2023
f6c12d8
add reference for the 'object'
furkanonder Mar 30, 2023
b1ab4a2
add reference for NotImplemented
furkanonder Mar 30, 2023
d709946
Change ref:`string <textseq>` as class:`str`
furkanonder Mar 31, 2023
105f331
remove hyphen from `newly-created`
furkanonder Mar 31, 2023
119e29b
Update Doc/reference/datamodel.rst
terryjreedy Jun 18, 2023
d8c1995
Merge branch 'main' into issue-60712
furkanonder Jun 7, 2024
7762a08
Update predefined attribute types in testPredefinedAttrs
furkanonder Jul 17, 2024
7ffed7c
Change `universal type` as `top type`
furkanonder Jul 17, 2024
5ad51b9
Merge branch 'main' into issue-60712
furkanonder Jul 20, 2024
71a2d43
Don't mention about the top type
furkanonder Aug 11, 2024
2d9f0a0
Update the description of richcmpfuncs
furkanonder Aug 11, 2024
10adcee
Update Doc/library/stdtypes.rst
furkanonder Aug 12, 2024
f9961eb
Merge branch 'main' into issue-60712
furkanonder Aug 12, 2024
ab5ef40
Revert: Hierarchy Section in Data Model Documentation
furkanonder Oct 17, 2024
6681f67
Revert to original explanations of __new__ and __init__ methods in da…
furkanonder Oct 20, 2024
7d68154
Merge branch 'main' into issue-60712
furkanonder Oct 20, 2024
3f41130
Update Doc/reference/datamodel.rst
furkanonder Oct 21, 2024
026e514
Remove blank line
furkanonder Oct 21, 2024
7181046
Use ref:`str <textseq>` instead of :class:`str
furkanonder Oct 21, 2024
69b710a
Merge branch 'main' into issue-60712
furkanonder Oct 21, 2024
55f8c6a
Revert changes the description of Other Built-in Types in stdtypes.rst
furkanonder Oct 21, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Doc/library/functions.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1283,9 +1283,10 @@ are always available. They are listed here in alphabetical order.

.. class:: object()

Return a new featureless object. :class:`object` is a base for all classes.
It has methods that are common to all instances of Python classes. This
function does not accept any arguments.
This is the ultimate base class of all other classes. It has methods
merwok marked this conversation as resolved.
Show resolved Hide resolved
that are common to all instances of Python classes. When the constructor
is called, it returns a new featureless object. The constructor does not
accept any arguments.

.. note::

Expand Down
5 changes: 3 additions & 2 deletions Doc/library/stdtypes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -5314,8 +5314,9 @@ instantiated from the type::
Other Built-in Types
====================

The interpreter supports several other kinds of objects. Most of these support
only one or two operations.
The interpreter supports several other kinds of objects, including instances
of the :class:`object` class itself. Most of these support only one or two
furkanonder marked this conversation as resolved.
Show resolved Hide resolved
operations.


.. _typesmodules:
Expand Down
57 changes: 39 additions & 18 deletions Doc/reference/datamodel.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1917,7 +1917,7 @@ Basic customization
class). The return value of :meth:`__new__` should be the new object instance
(usually an instance of *cls*).

Typical implementations create a new instance of the class by invoking the
Typical custom implementations create a new instance of the class by invoking the
furkanonder marked this conversation as resolved.
Show resolved Hide resolved
superclass's :meth:`__new__` method using ``super().__new__(cls[, ...])``
with appropriate arguments and then modifying the newly created instance
as necessary before returning it.
Expand Down Expand Up @@ -2033,7 +2033,8 @@ Basic customization
"informal" string representation of instances of that class is required.

This is typically used for debugging, so it is important that the representation
is information-rich and unambiguous.
is information-rich and unambiguous. A default implementation is provided by the
:class:`object` class itself.

.. index::
single: string; __str__() (object method)
Expand All @@ -2043,10 +2044,10 @@ Basic customization

.. method:: object.__str__(self)
Copy link
Member

@merwok merwok Oct 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we had a doc bug years ago where we came up with a convention to differentiate object.__str__ (actual method that exists in the object class), anyclass.__bases__ (method that exists on all class; explaining the data model) and someclass.__str__ (method you can define in your class to implement a protocol)

I guess we didn’t…


Called by :func:`str(object) <str>` and the built-in functions
:func:`format` and :func:`print` to compute the "informal" or nicely
Called by :func:`str(object) <str>`, the default :meth:`__format__` implementation,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this role (without class reference) create a proper link to the __format__ method doc?

Copy link
Contributor Author

@furkanonder furkanonder Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you click on :meth:`__format__, it directs you to object.__format__(self, format_spec)

and the built-in function :func:`print`, to compute the "informal" or nicely
printable string representation of an object. The return value must be a
:ref:`string <textseq>` object.
:class:`str` object.
furkanonder marked this conversation as resolved.
Show resolved Hide resolved

This method differs from :meth:`object.__repr__` in that there is no
expectation that :meth:`__str__` return a valid Python expression: a more
Expand All @@ -2063,7 +2064,8 @@ Basic customization
.. index:: pair: built-in function; bytes

Called by :ref:`bytes <func-bytes>` to compute a byte-string representation
of an object. This should return a :class:`bytes` object.
of an object. This should return a :class:`bytes` object. The :class:`object`
class itself does not provide this method.

.. index::
single: string; __format__() (object method)
Expand All @@ -2087,6 +2089,9 @@ Basic customization

The return value must be a string object.

The default implementation by the :class:`object` class should be given
an empty *format_spec* string. It delegates to :meth:`__str__`.

.. versionchanged:: 3.4
The __format__ method of ``object`` itself raises a :exc:`TypeError`
if passed any non-empty string.
Expand Down Expand Up @@ -2129,6 +2134,12 @@ Basic customization
``(x<y or x==y)`` does not imply ``x<=y``. To automatically generate ordering
operations from a single root operation, see :func:`functools.total_ordering`.

By default, the :class:`object` class provides implementations consistent
with :ref:`expressions-value-comparisons`: equality compares according to
object identity, and order comparisons raise :exc:`TypeError`. Each default
method may generate these results directly, but may also return
:data:`NotImplemented`.

See the paragraph on :meth:`__hash__` for
some important notes on creating :term:`hashable` objects which support
custom comparison operations and are usable as dictionary keys.
Expand Down Expand Up @@ -2183,10 +2194,10 @@ Basic customization
immutable (if the object's hash value changes, it will be in the wrong hash
bucket).

User-defined classes have :meth:`__eq__` and :meth:`__hash__` methods
by default; with them, all objects compare unequal (except with themselves)
and ``x.__hash__()`` returns an appropriate value such that ``x == y``
implies both that ``x is y`` and ``hash(x) == hash(y)``.
User-defined classes (and the :class:`object` class itself) have :meth:`__eq__`
and :meth:`__hash__` methods by default; with them, all objects compare
unequal (except with themselves) and ``x.__hash__()`` returns an appropriate
value such that ``x == y`` implies both that ``x is y`` and ``hash(x) == hash(y)``.

A class that overrides :meth:`__eq__` and does not define :meth:`__hash__`
will have its :meth:`__hash__` implicitly set to ``None``. When the
Expand Down Expand Up @@ -2236,8 +2247,8 @@ Basic customization
``bool()``; should return ``False`` or ``True``. When this method is not
defined, :meth:`~object.__len__` is called, if it is defined, and the object is
considered true if its result is nonzero. If a class defines neither
:meth:`!__len__` nor :meth:`!__bool__`, all its instances are considered
true.
:meth:`!__len__` nor :meth:`!__bool__` (which is true of the :class:`object`
class itself), all its instances are considered true.


.. _attribute-access:
Expand All @@ -2259,6 +2270,7 @@ access (use of, assignment to, or deletion of ``x.name``) for class instances.
for ``self``; or :meth:`__get__` of a *name* property raises
:exc:`AttributeError`). This method should either return the (computed)
attribute value or raise an :exc:`AttributeError` exception.
The :class:`object` class itself does not provide this method.

Note that if the attribute is found through the normal mechanism,
:meth:`__getattr__` is not called. (This is an intentional asymmetry between
Expand Down Expand Up @@ -2397,8 +2409,8 @@ method (a so-called *descriptor* class) appears in an *owner* class (the
descriptor must be in either the owner's class dictionary or in the class
dictionary for one of its parents). In the examples below, "the attribute"
refers to the attribute whose name is the key of the property in the owner
class' :attr:`~object.__dict__`.

class' :attr:`~object.__dict__`. The :class:`object` class itself does not
implement any of these protocols.

.. method:: object.__get__(self, instance, owner=None)

Expand Down Expand Up @@ -3090,17 +3102,18 @@ Emulating callable objects

Called when the instance is "called" as a function; if this method is defined,
``x(arg1, arg2, ...)`` roughly translates to ``type(x).__call__(x, arg1, ...)``.

The :class:`object` class itself does not provide this method.
furkanonder marked this conversation as resolved.
Show resolved Hide resolved

.. _sequence-types:

Emulating container types
-------------------------

The following methods can be defined to implement container objects. Containers
usually are :term:`sequences <sequence>` (such as :class:`lists <list>` or
The following methods can be defined to implement container objects. None of them
are provided by the :class:`object` class itself. Containers usually are
:term:`sequences <sequence>` (such as :class:`lists <list>` or
:class:`tuples <tuple>`) or :term:`mappings <mapping>` (like
:class:`dictionaries <dict>`),
:term:`dictionaries <dictionary>`),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Hm… on the line before, we see a general term used (with a link to glossary) and a concrete example in parens (list and tuple links), then we have the general/glossary term mappings and should keep the specific type dict in parens to keep the intent of the text. On the other hand, if the glossary term for dictionaries is a better explanation than the dict type/function doc, and more specific than the term for mappings, the changed link could be an improvement.

but can represent other containers as well. The first set of methods is used
either to emulate a sequence or to emulate a mapping; the difference is that for
a sequence, the allowable keys should be the integers *k* for which ``0 <= k <
Expand Down Expand Up @@ -3460,6 +3473,7 @@ Typical uses of context managers include saving and restoring various kinds of
global state, locking and unlocking resources, closing opened files, etc.

For more information on context managers, see :ref:`typecontextmanager`.
The :class:`object` class itself does not provide the context manager methods.


.. method:: object.__enter__(self)
Expand Down Expand Up @@ -3709,6 +3723,8 @@ are awaitable.
Must return an :term:`iterator`. Should be used to implement
:term:`awaitable` objects. For instance, :class:`asyncio.Future` implements
this method to be compatible with the :keyword:`await` expression.
The :class:`object` class itself is not awaitable and does not provide
this method.

.. note::

Expand Down Expand Up @@ -3794,6 +3810,9 @@ its ``__anext__`` method.

Asynchronous iterators can be used in an :keyword:`async for` statement.

The :class:`object` class itself does not provide these methods.


.. method:: object.__aiter__(self)

Must return an *asynchronous iterator* object.
Expand Down Expand Up @@ -3840,6 +3859,8 @@ suspend execution in its ``__aenter__`` and ``__aexit__`` methods.

Asynchronous context managers can be used in an :keyword:`async with` statement.

The :class:`object` class itself does not provide these methods.

.. method:: object.__aenter__(self)

Semantically similar to :meth:`~object.__enter__`, the only
Expand Down
50 changes: 50 additions & 0 deletions Lib/test/test_class.py
Original file line number Diff line number Diff line change
Expand Up @@ -503,6 +503,56 @@ def __eq__(self, other): return 1

self.assertRaises(TypeError, hash, C2())

def testPredefinedAttrs(self):
o = object()

class Custom:
pass

c = Custom()

methods = (
'__class__', '__delattr__', '__dir__', '__eq__', '__format__',
'__ge__', '__getattribute__', '__getstate__', '__gt__', '__hash__',
'__init__', '__init_subclass__', '__le__', '__lt__', '__ne__',
'__new__', '__reduce__', '__reduce_ex__', '__repr__',
'__setattr__', '__sizeof__', '__str__', '__subclasshook__'
)
for name in methods:
furkanonder marked this conversation as resolved.
Show resolved Hide resolved
with self.subTest(name):
self.assertTrue(callable(getattr(object, name, None)))
self.assertTrue(callable(getattr(o, name, None)))
self.assertTrue(callable(getattr(Custom, name, None)))
self.assertTrue(callable(getattr(c, name, None)))

not_defined = [
'__abs__', '__aenter__', '__aexit__', '__aiter__', '__anext__',
'__await__', '__bool__', '__bytes__', '__ceil__',
'__complex__', '__contains__', '__del__', '__delete__',
'__delitem__', '__divmod__', '__enter__', '__exit__',
'__float__', '__floor__', '__get__', '__getattr__', '__getitem__',
'__index__', '__int__', '__invert__', '__iter__', '__len__',
'__length_hint__', '__missing__', '__neg__', '__next__',
'__objclass__', '__pos__', '__rdivmod__', '__reversed__',
'__round__', '__set__', '__setitem__', '__trunc__'
]
augment = (
'add', 'and', 'floordiv', 'lshift', 'matmul', 'mod', 'mul', 'pow',
'rshift', 'sub', 'truediv', 'xor'
)
not_defined.extend(map("__{}__".format, augment))
not_defined.extend(map("__r{}__".format, augment))
not_defined.extend(map("__i{}__".format, augment))
for name in not_defined:
with self.subTest(name):
self.assertFalse(hasattr(object, name))
self.assertFalse(hasattr(o, name))
self.assertFalse(hasattr(Custom, name))
self.assertFalse(hasattr(c, name))

# __call__() is defined on the metaclass but not the class
self.assertFalse(hasattr(o, "__call__"))
self.assertFalse(hasattr(c, "__call__"))

def testSFBug532646(self):
# Test for SF bug 532646
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Include the :class:`object` type in the lists of documented types.
Change by Furkan Onder and Martin Panter.
Loading