Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-102947: Improve traceback when calling fields() on a non-dataclass #102948

Merged
merged 2 commits into from
Mar 23, 2023
Merged

gh-102947: Improve traceback when calling fields() on a non-dataclass #102948

merged 2 commits into from
Mar 23, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Mar 23, 2023 •
edited by bedevere-bot
Loading

@AlexWaygood AlexWaygood requested a review from carljm March 23, 2023 13:33
@AlexWaygood AlexWaygood requested a review from ericvsmith as a code owner March 23, 2023 13:33
@bedevere-bot bedevere-bot mentioned this pull request Mar 23, 2023
Closed
@AlexWaygood AlexWaygood added the stdlib Python modules in the Lib dir label Mar 23, 2023
@AlexWaygood
Copy link
Member Author

I'm unsure whether this counts as a feature or a backportable bugfix. I'm easy either way.

ericvsmith
ericvsmith approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@ericvsmith
Copy link
Member

I'm unsure whether this counts as a feature or a backportable bugfix. I'm easy either way.

I'd vote for bug fix.

@AlexWaygood AlexWaygood added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Mar 23, 2023
@AlexWaygood AlexWaygood merged commit baf4eb0 into python:main Mar 23, 2023
@miss-islington
Copy link
Contributor

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@AlexWaygood AlexWaygood deleted the dataclasses-traceback branch March 23, 2023 14:18
@miss-islington
Copy link
Contributor

Sorry, @AlexWaygood, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker baf4eb083c09b323cc12b8636c28c14089b87de8 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 23, 2023
@AlexWaygood @miss-islington
pythongh-102947: Improve traceback when calling fields() on a non-d…
d419d25 
…ataclass (pythonGH-102948)

(cherry picked from commit baf4eb0)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-bot
Copy link

GH-102951 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 23, 2023
@bedevere-bot
Copy link

GH-102954 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Mar 23, 2023
AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request Mar 23, 2023
@AlexWaygood
[3.10] pythongh-102947: Improve traceback when calling fields() on …
e25b3d8 
…a non-dataclass (python#102948)
miss-islington added a commit that referenced this pull request Mar 23, 2023
@miss-islington @AlexWaygood
gh-102947: Improve traceback when calling fields() on a non-datacla…
6ffeeb2 
…ss (GH-102948)

(cherry picked from commit baf4eb0)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood added a commit that referenced this pull request Mar 23, 2023
@AlexWaygood
[3.10] gh-102947: Improve traceback when calling fields() on a non-…
4531fd0 
…dataclass (#102948) (#102954)
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
@AlexWaygood @Fidget-Spinner
pythongh-102947: Improve traceback when calling fields() on a non-d…
4ef8efa 
…ataclass (python#102948)
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@AlexWaygood @warsaw
pythongh-102947: Improve traceback when calling fields() on a non-d…
3b287f6 
…ataclass (python#102948)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvsmith ericvsmith ericvsmith approved these changes

@carljm carljm Awaiting requested review from carljm

Assignees

@AlexWaygood AlexWaygood

Labels
stdlib Python modules in the Lib dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexWaygood @ericvsmith @miss-islington @bedevere-bot