gh-102890: Fix error handling in posix.stat implementation #102891
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* made `fill_time` function return 0 on error and 1 on success * added NULL check of value returned by `_pystat_l128_from_l64_l64` call in `_pystat_fromstructstat` * added checks verifying that calls to `fill_time` didn't fail in `_pystat_fromstructstat` * removed reference to non-existent `posix_fstat` function * added test
sobolevn
reviewed
Mar 22, 2023
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
Please, also add a NEWS entry.
…ystat_fromstructstat` comment
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
@sobolevn, could you review this PR again? |
Contributor
Author
|
I close this in favor of #109618. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102890
posix.statimplementation leads to crash on interrupt #102890