Tweak polynomial itertool recipes #102880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-bot
added
docs
Fidget-Spinner
pushed a commit
to Fidget-Spinner/cpython
that referenced
this pull request
Mar 27, 2023
Ah, I showed you the right algorithm but the wrong implementation. Beautifully done with |
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying
reversedto the range object instead of coefficients reduces the requirements for the coefficients. Now, only__iter__and__len__are needed. Formerly, either__getitem__or__reversed__were needed as well.Express the
polynomial_from_rootsrecipe in terms ofconvolve()this better matches the way it would be done by hand. Also, it nicely demonstrates iterator nesting. The previous version was meant to show-off an application ofcombinationsbut that was already demonstrated in thepowerset()recipe.