-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
gh-91896: Deprecate collections.abc.ByteString #102096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
804dfa1
gh-91896: Deprecate collections.abc.ByteString
hauntsaninja 4c7eace
add back a whitespace
hauntsaninja d534015
docs
hauntsaninja 476a259
typing docs
hauntsaninja 46404a0
pep 688 docs
hauntsaninja b1b4fd2
📜🤖 Added by blurb_it.
blurb-it[bot] dc22a74
what's new, removed
hauntsaninja eeaff44
move to pending removal
hauntsaninja 8777d29
add test
hauntsaninja c053777
Merge branch 'main' into gh-91896
hauntsaninja 4523ef0
Merge branch 'main' into gh-91896
hauntsaninja c23e1ad
Merge branch 'main' into gh-91896
AlexWaygood f774692
Merge branch 'main' into gh-91896
hugovk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1071,8 +1071,27 @@ def count(self, value): | |
Sequence.register(range) | ||
Sequence.register(memoryview) | ||
|
||
|
||
class ByteString(Sequence): | ||
class _DeprecateByteStringMeta(ABCMeta): | ||
def __new__(cls, name, bases, namespace, **kwargs): | ||
if name != "ByteString": | ||
import warnings | ||
|
||
warnings._deprecated( | ||
hauntsaninja marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"collections.abc.ByteString", | ||
remove=(3, 14), | ||
) | ||
return super().__new__(cls, name, bases, namespace, **kwargs) | ||
|
||
def __instancecheck__(cls, instance): | ||
import warnings | ||
|
||
warnings._deprecated( | ||
"collections.abc.ByteString", | ||
remove=(3, 14), | ||
) | ||
return super().__instancecheck__(instance) | ||
|
||
class ByteString(Sequence, metaclass=_DeprecateByteStringMeta): | ||
hauntsaninja marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"""This unifies bytes and bytearray. | ||
|
||
XXX Should add all their methods. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can also remove this comment. |
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Library/2023-03-08-02-45-46.gh-issue-91896.kgON_a.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Deprecate :class:`collections.abc.ByteString` | ||
hugovk marked this conversation as resolved.
Show resolved
Hide resolved
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.