bpo-35089: Don't mention typing.io and typing.re #10173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
approved these changes
Oct 28, 2018
|
I suggest you add a NEWS entry. |
ilevkivskyi
reviewed
Oct 28, 2018
| and ``BinaryIO``, deriving from ``IO[str]`` and ``IO[bytes]``, | ||
| respectively. These represent the types of I/O streams such as returned by | ||
| Generic type ``IO[AnyStr]`` and subclasses ``TextIO(IO[str])`` | ||
| and ``BinaryIO(IO[bytes])`` |
There was a problem hiding this comment.
I actually like the original formulation more. But this one is also fine.
There was a problem hiding this comment.
The problem is that "This defined" is now wrong, but when removing the verb you have to reformulate. I first ended up with:
The generic type
IO[AnyStr]and subclassesTextIOandBinaryIO, deriving fromIO[str]andIO[bytes], respectively, represent the types of I/O streams such as returned byopen.
But I found this hard to understand.
There was a problem hiding this comment.
@srittau You can also try splitting the sentence in two parts. Anyway, this is not very important.
|
Thanks @srittau for the PR, and @ilevkivskyi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 28, 2018
https://bugs.python.org/issue35089 (cherry picked from commit c8a8d6b) Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
|
GH-10177 is a backport of this pull request to the 3.7 branch. |
|
GH-10178 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 28, 2018
https://bugs.python.org/issue35089 (cherry picked from commit c8a8d6b) Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
miss-islington
added a commit
that referenced
this pull request
Oct 28, 2018
https://bugs.python.org/issue35089 (cherry picked from commit c8a8d6b) Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
miss-islington
added a commit
that referenced
this pull request
Oct 28, 2018
https://bugs.python.org/issue35089 (cherry picked from commit c8a8d6b) Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
srittau
added a commit
to srittau/cpython
that referenced
this pull request
May 13, 2021
They were originally removed in pythonGH-10173 per bpo-35089, but then readded in pythonGH-21574. Cf. bpo-38291 for decision to remove.
gvanrossum
pushed a commit
that referenced
this pull request
Jun 14, 2021
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 14, 2021
…26113) They were originally removed in pythonGH-10173 per bpo-35089, but then readded in pythonGH-21574. Cf. bpo-38291 for decision to remove. (cherry picked from commit 8a76683) Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 14, 2021
…26113) They were originally removed in pythonGH-10173 per bpo-35089, but then readded in pythonGH-21574. Cf. bpo-38291 for decision to remove. (cherry picked from commit 8a76683) Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
miss-islington
added a commit
that referenced
this pull request
Jun 14, 2021
miss-islington
added a commit
that referenced
this pull request
Jun 14, 2021
jdevries3133
pushed a commit
to jdevries3133/cpython
that referenced
this pull request
Jun 19, 2021
…26113) They were originally removed in pythonGH-10173 per bpo-35089, but then readded in pythonGH-21574. Cf. bpo-38291 for decision to remove.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue35089