Doctest: Pin sphinxext-opengraph==0.7.5 to prevent importing NumPy#101642
Merged
ambv merged 1 commit intopython:mainfrom Feb 7, 2023
Merged
Doctest: Pin sphinxext-opengraph==0.7.5 to prevent importing NumPy#101642ambv merged 1 commit intopython:mainfrom
ambv merged 1 commit intopython:mainfrom
Conversation
hugovk
force-pushed
the
pin-sphinxext-opengraph
branch
from
1abf729 to
97040ec
Compare
hugovk
changed the title
Contributor
Contributor
|
Sorry @hugovk and @ambv, I had trouble checking out the |
This was referenced Feb 7, 2023
ZeroIntensity
removed
awaiting core review
needs backport to 3.11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use a Sphinx extension to help with SEO metadata. They recently added (in 0.8.0) support for generating images for social media cards (sphinx-doc/sphinxext-opengraph#88). We're not using that feature, but it still attempts to install and import Matplotlib and its dependency NumPy, which can fail the doctest for 3.12/
maindue to incompatibilities.For now, let's pin to the previous version, sphinxext-opengraph==0.7.5, and make another fix later (see: #101639 (comment)).