Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-101632: Add a RETURN_CONST instruction #101633

Merged
merged 6 commits into from
Feb 7, 2023

Conversation

penguin-wwy
Copy link
Contributor

@penguin-wwy penguin-wwy commented Feb 7, 2023

@iritkatriel
Copy link
Member

Do you see a difference in any benchmarks?

@penguin-wwy
Copy link
Contributor Author

I am executing pyperformance, please wait :)

@penguin-wwy
Copy link
Contributor Author

@iritkatriel I update the pyperformance result in issue
#101632 (comment)

@arhadthedev arhadthedev added the performance Performance or resource usage label Feb 7, 2023
@iritkatriel
Copy link
Member

@iritkatriel I update the pyperformance result in issue
#101632 (comment)

Thanks, I'll try to replicate on our benchmark machine.

@iritkatriel
Copy link
Member

@iritkatriel I update the pyperformance result in issue
#101632 (comment)

Thanks, I'll try to replicate on our benchmark machine.

Also came out 1% faster.

Results are here.

@penguin-wwy
Copy link
Contributor Author

@iritkatriel I update the pyperformance result in issue
#101632 (comment)

Thanks, I'll try to replicate on our benchmark machine.

Also came out 1% faster.

Results are here.

Thanks. It turned out a little better than I expected.

@iritkatriel iritkatriel added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Feb 7, 2023
@iritkatriel iritkatriel changed the title gh-101632: Add return const instruction gh-101632: Add a RETURN_CONST instruction Feb 7, 2023
Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 7, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit afba682 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 7, 2023
@iritkatriel
Copy link
Member

The "s390x Fedora Refleaks PR" buildbot is broken (for a few months at least). All other test runs were successful.

@iritkatriel iritkatriel merged commit 753fc8a into python:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants