gh-100762: Switch order of exception match in gen_close#101011
Closed
eendebakpt wants to merge 6 commits intopython:mainfrom
Closed
gh-100762: Switch order of exception match in gen_close#101011eendebakpt wants to merge 6 commits intopython:mainfrom
eendebakpt wants to merge 6 commits intopython:mainfrom
Conversation
brandtbucher
approved these changes
May 10, 2023
Member
brandtbucher
left a comment
There was a problem hiding this comment.
Seems good. Let's wait for 3.13 in two weeks, since performance improvements are effectively frozen right now.
Contributor
Author
@brandtbucher Thanks for looking into this. The main branch has changed in the meantime, and there is currently only a single match instead of the two before. This makes this PR irrelevant, I will close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes the closing of generators by switching the match statements in the expression
PyErr_ExceptionMatches(PyExc_StopIteration) || PyErr_ExceptionMatches(PyExc_GeneratorExit)from thegen_closemethod. The case of aPyExc_GeneratorExitis more common.Benchmark (with optimizations including PGO) updated May 9th:
Benchmark script:
Notes:
PyExc_StopIterationis triggered occur less than thePyExc_GeneratorExit. Cases from the python test suite aretest_async_gen_asyncio_aclose_10intest_asyncgen.pyand the following code fromtest_generators.py: