-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-100809: Fix handling of drive-relative paths in pathlib.Path.absolute() #100812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
28e7831
gh-100809: Fix handling of drive-relative paths in pathlib.Path.absol…
barneygale 4b5d333
Call _getfullpathname() on the drive (if any), not the full path
barneygale d2649a6
Undo unnecessary test changes
barneygale 2271a4e
Stop handling ValueError and OSError from _getfullpathname()
barneygale ad9db67
Add test for drive-specific current directory on non-current drive.
barneygale 4bb81ee
Apply suggestions from code review
barneygale 5dd9af2
Move DOS device constants into `try:` block
barneygale b19e6a0
Tidy up test code slightly
barneygale 5e1d4aa
Simplify implementation
barneygale ce26d13
Merge branch 'main' into gh-100809-path-absolute-nt
barneygale 5f1cf01
Update Misc/NEWS.d/next/Library/2023-01-06-21-14-41.gh-issue-100809.I…
barneygale File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
Misc/NEWS.d/next/Library/2023-01-06-21-14-41.gh-issue-100809.I697UT.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
Fix handling of drive-relative paths (like 'C:' and 'C:foo') in | ||
:meth:`pathlib.Path.absolute`. This method now uses the OS API | ||
to retrieve the correct current working directory for the drive. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.