gh-100546: Remove incorrect positional-only marker from eval #100547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the arguments are positional-only. The current status after python#99476 seems to be to not use positional-only markers in documentation, hence I've simply removed it. That said, there are still three other positional-only markers in this file). I asked for clarification in python#100546 (comment). See also python#98340
bedevere-bot
added
awaiting core review
docs
hauntsaninja
added
needs backport to 3.11
|
Only needs backporting to 3.11 because #96579 (and subsequent partial reverts) only got backported to 3.11 (seems not particularly intentionally, seems just because automatic backporting failed) |
sobolevn
approved these changes
Dec 28, 2022
AlexWaygood
approved these changes
Dec 30, 2022
|
Thanks @hauntsaninja for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-100654 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 1, 2023
…ythonGH-100547) All the arguments are positional-only. The current status after pythonGH-99476 seems to be to not use positional-only markers in documentation, hence I've simply removed it. (cherry picked from commit 71159a8) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the arguments are positional-only.
The current status after #99476 seems to be to not use positional-only markers in documentation, hence I've simply removed it.
That said, there are still three other positional-only markers in this file). I asked for clarification in
#100546 (comment).
See also #98340