gh-87688: Amend SSLContext.hostname_checks_common_name docs #100517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alex (as the ssl expert), would you mind to review and possibly merge this PR? It improves a factual error in the OpenSSL version mentioned in |
AA-Turner
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
The said commit does seem to appear in 1.1.1l: https://github.com/openssl/openssl/commits/OpenSSL_1_1_1l/?author=tiran, but not 1.1.1k: https://github.com/openssl/openssl/commits/OpenSSL_1_1_1k/?author=tiran
A
erlend-aasland
changed the title
ssl.rst
serhiy-storchaka
approved these changes
Feb 17, 2024
serhiy-storchaka
added
needs backport to 3.11
|
Thanks @ramikg for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 17, 2024
…thonGH-100517) (cherry picked from commit debb138) Co-authored-by: Rami <72725910+ramikg@users.noreply.github.com>
|
GH-115594 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 17, 2024
…thonGH-100517) (cherry picked from commit debb138) Co-authored-by: Rami <72725910+ramikg@users.noreply.github.com>
|
GH-115595 is a backport of this pull request to the 3.11 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Feb 17, 2024
serhiy-storchaka
pushed a commit
that referenced
this pull request
Feb 17, 2024
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
LukasWoodtli
pushed a commit
to LukasWoodtli/cpython
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #87688, the bug affecting
SSLContext.hostname_checks_common_namewas fixed in openssl/openssl@dfccfde, which was introduced in OpenSSL 1.1.1l (and not 1.1.1k as in the docs).