gh-87771: Improve documentation of eval() #100003
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slateny
commented
Dec 6, 2022
| environment where :func:`eval` is called. If only the *globals* argument is | ||
| provided, the local namespace defaults to *globals*. | ||
|
|
||
| Before evaluation, the special key ``"__builtins__"`` is searched for in the |
There was a problem hiding this comment.
Not too certain about quoting the key, and perhaps it could be non-literal and just "builtins" instead, but I'll defer judgement here.
slateny
commented
Dec 6, 2022
iritkatriel
reviewed
Dec 7, 2022
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
✅ Deploy Preview for python-cpython-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This has been superseded by #119235 and its follow-ups (the exec/eval docs have also been more generally updated for PEP 667, hence the conflicts on this PR) Thanks for the efforts here, even though they ultimately weren't merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clone of the eval section of #25039 with conflicts fixed and some changes in phrasing, but wording kept mostly the same.
See this for discussion on 'condition list' and why it was changed to 'expression input'.
https://docs.python.org/dev/library/functions.html#eval
Co-authored-by: Cong Ma cong.ma@obspm.fr