PyThreadState_IsCurrent bug under building Python with --with-experimental-isolated-subinterpreters #88540

Activity

1. JunyiXie commented on Jun 10, 2021

   

   JunyiXiemannequin

   on Jun 10, 2021

   MannequinAuthor

   More actions

   under building Python with --with-experimental-isolated-subinterpreters
   PyThreadState_IsCurrent use _PyRuntime.gilstate. is shared by multi sub interpreters.
   Use interpreter gil->last_holder == state can fix it?

   static int
   PyThreadState_IsCurrent(PyThreadState *tstate)
   {
       /* Must be the tstate for this thread */
       struct _gilstate_runtime_state *gilstate = &_PyRuntime.gilstate;
       assert(_PyGILState_GetThisThreadState(gilstate) == tstate);
       return tstate == _PyRuntimeGILState_GetThreadState(gilstate);
   }
   

   static int
   PyThreadState_IsCurrent(PyThreadState *tstate)
   {
   #ifdef EXPERIMENTAL_ISOLATED_SUBINTERPRETERS
       PyInterpreterState *interp = tstate->interp;
       struct _ceval_state *ceval2 = &interp->ceval;
       struct _gil_runtime_state *gil = &ceval2->gil;
       return tstate == (PyThreadState*)_Py_atomic_load_relaxed(&gil->last_holder);
   #else
       /* Must be the tstate for this thread */
       struct _gilstate_runtime_state *gilstate = &_PyRuntime.gilstate;
       assert(_PyGILState_GetThisThreadState(gilstate) == tstate);
       return tstate == _PyRuntimeGILState_GetThreadState(gilstate);
   #endif
   }
   
2. JunyiXie

   added

   3.11only security fixesonly security fixes

   topic-subinterpreters

   on Jun 10, 2021
3. ezio-melotti

   transferred this issue fromon Apr 10, 2022
4. ezio-melotti

   added this to Subinterpreterson Apr 15, 2022
5. ezio-melotti

   moved this to Todo in Subinterpreterson Apr 15, 2022
6. kumaraditya303 commented on Jul 10, 2022

   

   kumaraditya303

   on Jul 10, 2022

   Contributor

   More actions

   Closing as EXPERIMENTAL_ISOLATED_SUBINTERPRETERS was removed in #93185
7. kumaraditya303

   closed this as not plannedon Jul 10, 2022
8. Repository owner moved this from Todo to Done in Subinterpreterson Jul 10, 2022