Repository navigation
canonicalize "upper-case" -> "uppercase"; "lower-case" -> "lowercase" #88211
Description
| BPO | 44045 |
|---|---|
| Nosy | @ericvsmith, @merwok, @jugmac00, @nanjekyejoannah, @akulakov |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = None
created_at = <Date 2021-05-05.06:55:02.631>
labels = []
title = 'canonicalize "upper-case" -> "uppercase"; "lower-case" -> "lowercase"'
updated_at = <Date 2021-05-28.20:54:32.055>
user = 'https://github.com/jugmac00'bugs.python.org fields:
activity = <Date 2021-05-28.20:54:32.055>
actor = 'nanjekyejoannah'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = []
creation = <Date 2021-05-05.06:55:02.631>
creator = 'jugmac00'
dependencies = []
files = []
hgrepos = []
issue_num = 44045
keywords = ['patch']
message_count = 10.0
messages = ['392978', '393065', '393217', '393227', '393229', '393248', '393284', '393292', '393293', '394689']
nosy_count = 5.0
nosy_names = ['eric.smith', 'eric.araujo', 'jugmac00', 'nanjekyejoannah', 'andrei.avk']
pr_nums = ['25985']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue44045'
versions = []
Activity
jugmac00 commentedon May 5, 2021
Yesterday, I was bitten by ConfigParser' default behavior to lowercase keys on reading.
When I looked in the documentation and the source code, I found that lowercase was sometimes written as "lower-case", e.g. here
https://docs.python.org/3/library/configparser.html#configparser.ConfigParser.optionxform
The webster dictionary only accepts "lowercase" as a valid English word:
https://www.merriam-webster.com/dictionary/lowercase
Before I wanted to create a pull request for this one, I also grepped the complete source code with the following result:
lower-case 24
lowercase 207
upper-case 9
uppercase 201
I'd like to create a pull request which canonicalizes the writing to a consistent "lowercase" resp. "uppercase".
Is there any core dev out there willing to review / merge this kind of PR?
ericvsmith commentedon May 6, 2021
I think we'd want to look at the 33 uses with hyphens to make sure removing the hyphen is correct (as opposed to just blindly make a change). But I'm generally supportive.
merwok commentedon May 7, 2021
I don’t think that there is a problem to be fixed.
Separated «lower case» could be unfriendly, but the hyphen is there in the adjective forms so it seems that changing these instances would add churn for no benefit.
jugmac00 commentedon May 7, 2021
I did some more research.
It looks like US English tends to use
lowercase, while British English tends tolower case, and as an alternative tolowercaseyou can also uselower-casewhen using it as an adjective.See also https://en.wiktionary.org/wiki/lowercase
So, to wrap up:
If that is true - I am no native English speaker, and Éric does not like to convert them all to single words, it gets a bit tougher.
Some - to me - obvious wrong usages would be:
"All IMAP4rev1 commands are supported by methods of the same name (in lower-case)."
=> in lower case or in lowercase
"All POP3 commands are represented by methods of the same name, in lower-case; most return the response text sent by the server."
=> in lower case or in lowercase
"Wrapper around a file that converts output to upper-case."
=> to upper case or to uppercase
"Return a new UUID, in the format that MSI typically requires (i.e. in curly braces, and with all hexdigits in upper-case)."
=> in upper case or in uppercase
"Hostnames are compared lower case."
=> lower-case or lowercase
Éric, are you ok with my suggested changes or do you want me to close the issue?
ericvsmith commentedon May 7, 2021
That's exactly the kind of manual check I had in mind. After all "anal retentive doesn't have a hyphen unless it's used as a compound adjective".
I think we should go with "lowercase" when a noun, and "lower-case" as an adjective.
jugmac00 commentedon May 8, 2021
Thank you for the feedback. I created a PR.
akulakov commentedon May 8, 2021
https://dictionary.cambridge.org/us/dictionary/english/lower-case lists lower-case as a valid variant for nouns as well as adjectives.
ericvsmith commentedon May 9, 2021
The stdlib seems to have settled on lowercase for the noun version, though. My two cents: no sense not being consist just because lower-case might also work.
akulakov commentedon May 9, 2021
On Sat, May 8, 2021 at 10:38 PM Eric V. Smith <report@bugs.python.org>
wrote:
Sounds good to me, I'm not opposed to consistency!
nanjekyejoannah commentedon May 28, 2021
New changeset 2138b2e by Jürgen Gmach in branch 'main':
bpo-44045: fix spelling of uppercase vs upper-case (GH-25985)
2138b2e
slateny commentedon Aug 2, 2022
In imaplib, the first sentence in that section there is this:
Should that be changed over too, or is this issue good to close?
nanjekyejoannah commentedon Aug 3, 2022
Yes, makes sense, you can open a PR if can.
Change lower-case and upper-case to match recommendations in python#8…
tbwolfe commentedon Nov 20, 2022
PR Submitted. Please let me know if there are any issues.
gh-88211: Change lower-case and upper-case to match recommendations i…
pythongh-88211: Change lower-case and upper-case to match recommendat…
Merged main into regmachine branch (#50)