test_pathlib assumes underlying filesystem permits creation with world-write permissions

[aixtools]

BPO	41461
Nosy	@serhiy-storchaka, @aixtools

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2020-08-03.07:06:46.172>
labels = ['3.8', 'type-bug', 'tests', '3.9', '3.10']
title = 'test_pathlib assumes underlying filesystem permits creation with world-write permissions'
updated_at = <Date 2021-03-30.21:42:43.099>
user = 'https://github.com/aixtools'

bugs.python.org fields:

activity = <Date 2021-03-30.21:42:43.099>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Tests']
creation = <Date 2020-08-03.07:06:46.172>
creator = 'Michael.Felt'
dependencies = []
files = []
hgrepos = []
issue_num = 41461
keywords = []
message_count = 2.0
messages = ['374725', '389860']
nosy_count = 2.0
nosy_names = ['serhiy.storchaka', 'Michael.Felt']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue41461'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']

Linked PRs

• GH-85633: Fix pathlib test failures on filesystems without world-write. #122883
• [3.13] GH-85633: Fix pathlib test failures on filesystems without world-write. (GH-122883) #122979

[aixtools]

Two tests in test_pathlib test that the files created have mode o666 (rw-rw-rw).

However, on a filesystem (in my case NFS) configured to never permit global write - the test will always fail.

Is this something to be concerned about?

I can think of a few possible ways to react to an exception such as this, e.g., rather than 'FAIL' outright, try umask(2).

++++++++
======================================================================
FAIL: test_open_mode (test.test_pathlib.PosixPathTest)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/data/prj/python/src/py38-3.8.5/Lib/test/test_pathlib.py", line 2210, in test_open_mode
    self.assertEqual(stat.S_IMODE(st.st_mode), 0o666)
AssertionError: 436 != 438

======================================================================
FAIL: test_touch_mode (test.test_pathlib.PosixPathTest)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/data/prj/python/src/py38-3.8.5/Lib/test/test_pathlib.py", line 2223, in test_touch_mode
    self.assertEqual(stat.S_IMODE(st.st_mode), 0o666)
AssertionError: 436 != 438

---

++++++++

Just to verify it does work when on a 'local' filesystem.

cp -rp build /tmp/build
mv build build.nfs
ln -s /tmp/build build

== Tests result: SUCCESS ==

1 test OK.

Total duration: 7.8 sec
Tests result: SUCCESS

[serhiy-storchaka]

umask(0o002) looks good idea (and perhaps umask(0o026) instead of umask(0o022)). Please add also a short explanation comment.