Crash in the get() method a single argument in dbm.ndbm

[serhiy-storchaka]

BPO	33383
Nosy	@serhiy-storchaka, @ZackerySpytz
PRs	bpo-33383: Fix crash in get() of the dbm.ndbm database object. #6630 [3.7] bpo-33383: Fix crash in get() of the dbm.ndbm database object. (GH-6630) #6631 [3.6] bpo-33383: Fix crash in get() of the dbm.ndbm database object. (GH-6630). #6633

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-04-29.14:08:46.970>
created_at = <Date 2018-04-29.08:09:38.078>
labels = ['extension-modules', '3.7', '3.8', 'type-crash']
title = 'Crash in the get() method a single argument in dbm.ndbm'
updated_at = <Date 2018-05-20.23:18:27.592>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2018-05-20.23:18:27.592>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2018-04-29.14:08:46.970>
closer = 'serhiy.storchaka'
components = ['Extension Modules']
creation = <Date 2018-04-29.08:09:38.078>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 33383
keywords = ['patch']
message_count = 6.0
messages = ['315883', '315885', '315889', '315891', '317193', '317208']
nosy_count = 2.0
nosy_names = ['serhiy.storchaka', 'ZackerySpytz']
pr_nums = ['6630', '6631', '6633']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'crash'
url = 'https://bugs.python.org/issue33383'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']

[serhiy-storchaka]

Calling the get() method of the dbm.ndbm database object with only single argument causes a crash because the default value is set to NULL.

The regression was introduce in 3.5.

The proposed patch fixes the crash and add tests for the get() method for all dbm implementations.

[serhiy-storchaka]

New changeset 2e38cc3 by Serhiy Storchaka in branch 'master':
bpo-33383: Fix crash in get() of the dbm.ndbm database object. (bpo-6630)
2e38cc3

[serhiy-storchaka]

New changeset ee95feb by Serhiy Storchaka (Miss Islington (bot)) in branch '3.7':
[3.7] bpo-33383: Fix crash in get() of the dbm.ndbm database object. (GH-6630) (GH-6631)
ee95feb

[serhiy-storchaka]

New changeset 1b27ec6 by Serhiy Storchaka in branch '3.6':
[3.6] bpo-33383: Fix crash in get() of the dbm.ndbm database object. (GH-6630). (GH-6633)
1b27ec6

[ZackerySpytz]

There was already an open issue for this (bpo-31868).

[serhiy-storchaka]

Thank you for reminder Zackery. I forgot about that issue!