Idle: update htest.py and htests

[terryjreedy]

BPO	22629
Nosy	@terryjreedy
Files	@htest-34.diff @htest-34-2.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/terryjreedy'
closed_at = None
created_at = <Date 2014-10-14.03:33:50.580>
labels = ['expert-IDLE', 'type-bug', '3.8']
title = 'Idle: update htest.py and htests'
updated_at = <Date 2019-02-21.00:50:19.172>
user = 'https://github.com/terryjreedy'

bugs.python.org fields:

activity = <Date 2019-02-21.00:50:19.172>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = False
closed_date = None
closer = None
components = ['IDLE']
creation = <Date 2014-10-14.03:33:50.580>
creator = 'terry.reedy'
dependencies = []
files = ['36906', '36954']
hgrepos = []
issue_num = 22629
keywords = ['patch']
message_count = 5.0
messages = ['229278', '229565', '229566', '229567', '336168']
nosy_count = 3.0
nosy_names = ['terry.reedy', 'python-dev', 'Saimadhav.Heblikar']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'needs patch'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue22629'
versions = ['Python 3.8']

Linked PRs

• gh-66819: More IDLE htest updates #112574
• [3.12] gh-66819: More IDLE htest updates (GH-112574) #112575
• [3.11] gh-66819: More IDLE htest updates (GH-112574) #112576
• gh-66819: More IDLE htest updates(2) #112642
• [3.12] gh-66819: More IDLE htest updates(2) (GH-112642) #112643
• [3.11] gh-66819: More IDLE htest updates(2) (GH-112642) #112644
• gh-66819: More IDLE htest updates(3) #112683
• [3.12] gh-66819: More IDLE htest updates(3) (GH-112683) #112684
• [3.11] gh-66819: More IDLE htest updates(3) (GH-112683) #112685
• gh-66819: More IDLE htest updates(4) #112686
• [3.12] gh-66819: More IDLE htest updates(4) (GH-112686) #112688
• [3.11] gh-66819: More IDLE htest updates(4) (GH-112686) #112689

[terryjreedy]

After using idle-test/htest.py and individual htests when editing files, a few updates are needed.

1. Improve the docstring for htest.py; add info about "# htest #".

2. Use Toplevel(parent) instead of Tk() for test-specific childs windows of the main, master window. Currently, for some tests, such as CallTipWindow, the focus does not properly shift to the test window. Closing the master window first leaves the test window open. Closing the test window second then causes several tcl errors (printed to console if available), a Windows message, and an Idle freeze of 5 seconds or more before Idle works again. The change in this initial patch fixes the focus, non-close, error, and hang problems. One click and the test window is ready to go; one click on the master and both go away.

3. Coding style issues -- I prefer to use winfo_rootx/y, as done elsewhere in Idle, to using re (close call). For CallTipWindow, the inner class is not needed now, if it ever was.

[terryjreedy]

I reviewed and edited htest.py docstring and specs up to grep. Unfortunately, things were not quite alphabetical. Reviewed and edited corresponding idlelib module callables up to first line of grep._grep_dialog. I am pushing this as a first chunk.

Covered _calltip_window, ClassBrowser, _color_delegator, ConfigDialog, _dyn_option_menu, _editor_window, _grep_dialog. Checked x(parent), # htest #, (htest in widget), TopLevel(parent), winfo_x, bindings: see _calltip_window.

[python-dev]

New changeset f5be7fc270d1 by Terry Jan Reedy in branch '2.7':
Issue bpo-22629: Revise idle_test.htest, mostly docstring. Start revision of
https://hg.python.org/cpython/rev/f5be7fc270d1

New changeset e73f1d813f1f by Terry Jan Reedy in branch '3.4':
Issue bpo-22629: Revise idle_test.htest, mostly docstring. Start revision of
https://hg.python.org/cpython/rev/e73f1d813f1f

New changeset d8ac11794f26 by Terry Jan Reedy in branch 'default':
Merge with 3.4: Issue bpo-22629
https://hg.python.org/cpython/rev/d8ac11794f26

[terryjreedy]

As far as I can tell, the entire diff in @htest-34-2.diff was pushed. My comment about 'up to first line of grep' was correct alphabetically but confusing because files with a '# htest #' section were not completely alphabetical in the file. I need to review current code in light of this issue and a couple of others.

[terryjreedy]

First patch: Review docstring again. Alphabetize specs.
Later: Review spec and callable grep onwards.
Any closing issues not fixed in edit consider in #112569.