Attaching a PropertyMock records calls

[voidspace]

BPO	21255
Nosy	@merwok, @voidspace, @kushaldas, @tirkarthi

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/voidspace'
closed_at = None
created_at = <Date 2014-04-16.16:19:15.626>
labels = ['type-bug', 'library']
title = 'Attaching a PropertyMock records calls'
updated_at = <Date 2020-02-18.09:21:36.362>
user = 'https://github.com/voidspace'

bugs.python.org fields:

activity = <Date 2020-02-18.09:21:36.362>
actor = 'xtreak'
assignee = 'michael.foord'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2014-04-16.16:19:15.626>
creator = 'michael.foord'
dependencies = []
files = []
hgrepos = []
issue_num = 21255
keywords = []
message_count = 3.0
messages = ['216488', '216603', '217006']
nosy_count = 4.0
nosy_names = ['eric.araujo', 'michael.foord', 'kushal.das', 'xtreak']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'needs patch'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue21255'
versions = ['Python 3.4', 'Python 3.5']

Linked PRs

• gh-65454: avoid triggering call to a PropertyMock in NonCallableMock.__setattr__ #120019
• [3.13] gh-65454: avoid triggering call to a PropertyMock in NonCallableMock.__setattr__ (GH-120019) #120336
• [3.12] gh-65454: avoid triggering call to a PropertyMock in NonCallableMock.__setattr__ (GH-120019) #120337

[voidspace]

What steps will reproduce the problem?

    >>> foo = Mock(name='foo')
    >>> prop = PropertyMock(name='prop')
    >>> type(foo).prop = prop
    >>> foo.attach_mock(prop, 'prop')
    >>> foo.mock_calls
    [call.prop(<PropertyMock name='foo.prop' id='4300017296'>)]

Expected:

    >>> foo.mock_calls
    []

What version of the product are you using? On what operating system?

% pip freeze | grep mock
mock==1.0.1

OS X 10.8.4

Please provide any additional information below.

It would be even cooler if attaching a property mock made calls to the property appear in the mock_calls for the hosting mock without having to attach it, the way it does with a non-property method :)

I use mock every day now and am firmly of the opinion it is far, far more awesome than sliced bread. Thanks for making it available to the Python community :)

[merwok]

>> type(foo).prop = prop
>>> foo.attach_mock(prop, 'prop')

Are both of these lines needed?

[voidspace]

Not sure, but I guess it would be easy to find out. It will need some digging into to find out where the actual bug is. It shouldn't be hard to find though.

[hugovk]

@blhsing Thank you for fixing a 10-year-old issue! 🎉