Arguments `Clean` and `CleanAll` for argument `-t` of `batch.bat` do not work correctly in case of PGO builds on Windows

[chris-eibl]

When having a closer look at the new Windows PGO Tailcall build logs

• AMD64 Windows PGO Tailcall 3.x/1
• AMD64 Windows PGO NoGIL Tailcall 3.x/1

I've stumbled over

error : PGO run did not succeed (no python315!*.pgc files) and there is no data to merge

A closer look reveals that this happens on all Windows PGO builds in case of calling the Clean or CleanAll target. The culprit is here

cpython/PCbuild/build.bat

Lines 162 to 171 in 5944a53

	if "%do_pgo%"=="true" (
	del /s "%dir%\*.pgc"
	del /s "%dir%\..\Lib\*.pyc"
	echo on
	call "%dir%\..\python.bat" %pgo_job%
	@echo off
	call :Kill
	set conf=PGUpdate
	set target=Build
	)

where

• the pgo_job is always invoked
• and the target is always switched to target=Build

in the PGUpdate phase.

I'll send a PR shortly.

cc @itamaro

Linked PRs

• GH-145110: fix arguments Clean and CleanAll for argument -t of batch.bat in case of PGO builds on Windows #145111

[zooba]

I think you've chosen poor terminology here, though it may only impact me because I know without looking what "Clean/CleanAll targets" means 😉

You're referring solely to the batch file, so I'd title/label stuff in terms of the argument names, or at least clarify that you mean the batch file. The Clean and CleanAll targets in pcbuild.proj (presumably) do work correctly, since you aren't proposing to change them at all.