-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
Closed
Closed
Copy link
Labels
3.14bugs and security fixesbugs and security fixes3.15new features, bugs and security fixesnew features, bugs and security fixesstdlibPython modules in the Lib dirPython modules in the Lib dirtype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
Description
Bug report
Bug description:
The 3.14
branch and main
both fail to build with --enable-assertions
:
$ ./configure --with-assertions
$ make
[...]
gcc -fno-strict-overflow -Wsign-compare -g -O3 -Wall -std=c11 -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wstrict-prototypes -Werror=implicit-function-declaration -fvisibility=hidden -I./Include/internal -I./Include/internal/mimalloc -I. -I./Include -fPIC -c ./Modules/_zstd/compressor.c -o Modules/_zstd/compressor.o
In file included from ./Include/Python.h:19,
from ./Modules/_zstd/compressor.c:15:
./Modules/_zstd/compressor.c: In function ‘compress_mt_continue_lock_held’:
./Modules/_zstd/compressor.c:547:20: error: implicit declaration of function ‘mt_continue_should_break’ [-Wimplicit-function-declaration]
547 | assert(mt_continue_should_break(&in, &out));
| ^~~~~~~~~~~~~~~~~~~~~~~~
make: *** [Makefile:3579: Modules/_zstd/compressor.o] Error 1
I'll send a patch now.
CPython versions tested on:
CPython main branch
Operating systems tested on:
Linux
Linked PRs
Metadata
Metadata
Assignees
Labels
3.14bugs and security fixesbugs and security fixes3.15new features, bugs and security fixesnew features, bugs and security fixesstdlibPython modules in the Lib dirPython modules in the Lib dirtype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error