-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support parsing negative scientific notation and complex numbers in argparse #124693
Comments
That is why any changes should be treated with caution. I prefer not to merge the changes right now, but to wait for a while in case new circumstances arise. After all, this is not a very important case. In any case this is rather a new feature than a bug. |
That makes sense. I totally agree and understand the hesitancy. There are lots of inconsistencies like this lying around, and fixing any one of them could definitely have side effects. That said, I would like to understand what we are looking for in waiting. More specifically, what would we need to see to feel comfortable merging this change? Do you have specific criteria in mind? |
I do not know. It takes time to think things over. Perhaps new thoughts will arise while working on other issues. I thought about how it can affect cases such as Nothing wrong with your PR (as it looks to me now), and most likely it will be merged in a week or two. |
Thanks for clarifying. Just wanted to make sure that there wasn't anything else to be done here that could help! |
…gparse (GH-124823) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Even if I did not solve any related issues, I think that this change is on safe side. |
Bug report
Per #123945 (comment)
Linked PRs
The text was updated successfully, but these errors were encountered: