Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"test" GitHub Action workflow cannot be run manually #122965

Closed
nohlson opened this issue Aug 13, 2024 · 1 comment
Closed

"test" GitHub Action workflow cannot be run manually #122965

nohlson opened this issue Aug 13, 2024 · 1 comment
Labels
type-bug An unexpected behavior, bug, or error

Comments

@nohlson
Copy link
Contributor

nohlson commented Aug 13, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

With the inclusion of build_msi into the Change detection job of test workflow in #121778 it isn't possible to manually run the workflow anymore:

Screenshot 2024-08-13 at 12 52 04 AM

This seems to be because the Ana06/get-changed-files action doesn't support workflow_dispatch:

Screenshot 2024-08-13 at 12 57 34 AM

This type of error apparently does block CI.

I think the fix would be as simple as adding a condition that github.event_name == 'pull_request' to the Get a list of the MSI installer-related files step of the Compute changed files job.

Attn: @webknjaz

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux, macOS

Linked PRs
@nohlson nohlson added the type-bug An unexpected behavior, bug, or error label Aug 13, 2024
sobolevn added a commit to sobolevn/cpython that referenced this issue Aug 13, 2024
@sobolevn
pythongh-122965: Fix reusable-change-detection.yml on `workflow_dis…
fbd5a7e 
…patch`
@bedevere-app bedevere-app bot mentioned this issue Aug 13, 2024
Merged
hugovk pushed a commit that referenced this issue Aug 14, 2024
@sobolevn
gh-122965: Fix reusable-change-detection.yml on workflow_dispatch (…
6ae942f 
…#122966)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 14, 2024
@sobolevn @miss-islington
pythongh-122965: Fix reusable-change-detection.yml on `workflow_dis…
5a6d226 
…patch` (pythonGH-122966)

(cherry picked from commit 6ae942f)

Co-authored-by: sobolevn <mail@sobolevn.me>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 14, 2024
@sobolevn @miss-islington
pythongh-122965: Fix reusable-change-detection.yml on `workflow_dis…
741474b 
…patch` (pythonGH-122966)

(cherry picked from commit 6ae942f)

Co-authored-by: sobolevn <mail@sobolevn.me>
This was referenced Aug 14, 2024
Merged
Merged
sobolevn added a commit that referenced this issue Aug 14, 2024
@miss-islington @sobolevn
[3.12] gh-122965: Fix reusable-change-detection.yml on `workflow_di…
ecf9971 
…spatch` (GH-122966) (#123009)

gh-122965: Fix `reusable-change-detection.yml` on `workflow_dispatch` (GH-122966)
(cherry picked from commit 6ae942f)

Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn added a commit that referenced this issue Aug 14, 2024
@miss-islington @sobolevn
[3.13] gh-122965: Fix reusable-change-detection.yml on `workflow_di…
8644014 
…spatch` (GH-122966) (#123008)

gh-122965: Fix `reusable-change-detection.yml` on `workflow_dispatch` (GH-122966)
(cherry picked from commit 6ae942f)

Co-authored-by: sobolevn <mail@sobolevn.me>
@picnixz
Copy link
Contributor

picnixz commented Aug 16, 2024

Closing as this was completed in #122966.

@picnixz picnixz closed this as completed Aug 16, 2024
blhsing pushed a commit to blhsing/cpython that referenced this issue Aug 22, 2024
@sobolevn @blhsing
pythongh-122965: Fix reusable-change-detection.yml on `workflow_dis…
36c5102 
…patch` (python#122966)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nohlson @picnixz