Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure UX #115806

Open
erlend-aasland opened this issue Feb 22, 2024 · 3 comments · Fixed by #116165
Open

Configure UX #115806

erlend-aasland opened this issue Feb 22, 2024 · 3 comments · Fixed by #116165
Labels
build The build process and cross-build type-feature A feature request or enhancement

Comments

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Feb 22, 2024 •
edited by bedevere-app bot
Loading

Feature or enhancement

The LDLIBRARY and HOSTRUNNER checks overlap; this results in garbled output:

$ ./configure
[...]
checking LDLIBRARY... checking HOSTRUNNER... 
libpython$(VERSION)$(ABIFLAGS).a

The IPv6 library check is very subtle:

$ ./configure
[...]
configure: using libc

Suggesting to clean this up, for improved configure user experience:

$ ./configure
[...]
checking LDLIBRARY... libpython$(VERSION)$(ABIFLAGS).a
checking HOSTRUNNER...
[...]
checking ipv6 stack type... kame
checking ipv6 library... libc

Linked PRs
@erlend-aasland erlend-aasland added type-feature A feature request or enhancement build The build process and cross-build labels Feb 22, 2024
@bedevere-app bedevere-app bot mentioned this issue Feb 22, 2024
Merged
erlend-aasland added a commit that referenced this issue Feb 23, 2024
@erlend-aasland
gh-115806: Make configure output more readable (#115807)
e74cd0f 
- make sure LDLIBRARY and HOSTRUNNER checks don't overlap
- make the ipv6 library check less subtle
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Feb 29, 2024 •
edited
Loading

Ah, our PR gh-116016 mangled the output again:

checking ipv6 stack type... checking for IPV6_INRIA_VERSION defined in netinet/in.h... no
checking for __KAME__ defined in netinet/in.h... yes
kame

With #116165 applied, we get this:

checking for IPV6_INRIA_VERSION defined in netinet/in.h... no
checking for __KAME__ defined in netinet/in.h... yes
checking ipv6 stack type... kame
checking ipv6 library... libc

erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Feb 29, 2024
@erlend-aasland
pythongh-115806: Don't mangle output of configure 'ipv6 stack type' c…
808334f 
…heck
@bedevere-app bedevere-app bot mentioned this issue Feb 29, 2024
Merged
@erlend-aasland erlend-aasland linked a pull request Feb 29, 2024 that will close this issue
gh-115806: Don't mangle output of configure 'ipv6 stack type' check #116165
Merged
erlend-aasland added a commit that referenced this issue Mar 1, 2024
@erlend-aasland
gh-115806: Don't mangle output of configure 'ipv6 stack type' check (#…
41baa03 
…116165)
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this issue Mar 4, 2024
@erlend-aasland @woodruffw
pythongh-115806: Make configure output more readable (python#115807)
50cf0c4 
- make sure LDLIBRARY and HOSTRUNNER checks don't overlap
- make the ipv6 library check less subtle
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this issue Mar 4, 2024
@erlend-aasland @woodruffw
pythongh-115806: Don't mangle output of configure 'ipv6 stack type' c…
aca7e33 
…heck (python#116165)
adorilson pushed a commit to adorilson/cpython that referenced this issue Mar 25, 2024
@erlend-aasland @adorilson
pythongh-115806: Don't mangle output of configure 'ipv6 stack type' c…
4457ec7 
…heck (python#116165)
@erlend-aasland
Copy link
Contributor Author

configure -C still produces some garbled output:

checking for library containing dbm_open... (cached) -lgdbm_compat
checking for ndbm presence and linker args... yes (-lgdbm_compat)
(cached) (cached) checking for library containing dbm_open... -lgdbm_compat

diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@erlend-aasland @diegorusso
pythongh-115806: Make configure output more readable (python#115807)
bba9ae5 
- make sure LDLIBRARY and HOSTRUNNER checks don't overlap
- make the ipv6 library check less subtle
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@erlend-aasland @diegorusso
pythongh-115806: Don't mangle output of configure 'ipv6 stack type' c…
34fb811 
…heck (python#116165)
@hugovk
Copy link
Member

hugovk commented Jun 15, 2024

Triage: the linked PRs are merged, can this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build The build process and cross-build type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-115806: Don't mangle output of configure 'ipv6 stack type' check erlend-aasland/cpython
2 participants
@hugovk @erlend-aasland