Skip to content

pystats should save all metadata necessary to perform comparison in pystats .json output #109373

Closed
@mdboom

Description

@mdboom

Bug report

Bug description:

The Tools/scripts/summarize_stats.py script currently has the ability to save stats to a .json file so that collected stats can later be compared to another set of collected stats. Unfortunately, this comparison must be performed on the same version of Python that collected the stats, since information about specialized instructions and stats types are collected at runtime during the comparison (from the opcode module and by scraping the source code). Failure to do so may either break, or, worse, silently create incorrect results. If this information was instead stored in the .json file, the comparison could be formed on any recent enough build of Python, which is particularly important for the benchmarking infrastructure, where we don't want to have to checkout or rebuild specific versions of Python just to create derived comparative data.

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs

Metadata

Metadata

Assignees

No one assigned

    Labels

    type-bugAn unexpected behavior, bug, or error

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions