Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tkinter: test_getint incompatible with Tcl 9.0 #104411

Closed
Tracked by #104568
chrstphrchvz opened this issue May 12, 2023 · 1 comment
Closed
Tracked by #104568

Tkinter: test_getint incompatible with Tcl 9.0 #104411

chrstphrchvz opened this issue May 12, 2023 · 1 comment
Labels
topic-tkinter

Comments

@chrstphrchvz
Copy link
Contributor

chrstphrchvz commented May 12, 2023 •
edited by bedevere-bot
Loading

TIP 114 means that as of Tcl 9.0, integers are only treated as octal when the 0o prefix is specified; a leading 0 by itself is no longer sufficient. This change partially breaks test_getint:

======================================================================
FAIL: test_getint (test.test_tcl.TclTest.test_getint)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/user/git/cpython/Lib/test/test_tcl.py", line 145, in test_getint
    self.assertEqual(tcl.getint((' %#o ' % i).replace('o', '')), i)
AssertionError: 17777777777 != 2147483647

Linked PRs
chrstphrchvz added a commit to chrstphrchvz/cpython that referenced this issue May 12, 2023
@chrstphrchvz
pythongh-104411: Update test_getint for Tcl 9.0
9f8b855
@bedevere-bot bedevere-bot mentioned this issue May 12, 2023
Merged
@terryjreedy

This comment was marked as outdated.

Sign in to view
@terryjreedy terryjreedy mentioned this issue May 16, 2023
Open
16 tasks
serhiy-storchaka pushed a commit that referenced this issue Jun 6, 2023
@chrstphrchvz
gh-104411: Update test_getint for Tcl 9.0 (GH-104412)
2c49c75
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 6, 2023
@chrstphrchvz @miss-islington
pythongh-104411: Update test_getint for Tcl 9.0 (pythonGH-104412)
25e2928 
(cherry picked from commit 2c49c75)

Co-authored-by: Christopher Chavez <chrischavez@gmx.us>
@bedevere-bot bedevere-bot mentioned this issue Jun 6, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 6, 2023
@chrstphrchvz @miss-islington
pythongh-104411: Update test_getint for Tcl 9.0 (pythonGH-104412)
993b9cf 
(cherry picked from commit 2c49c75)

Co-authored-by: Christopher Chavez <chrischavez@gmx.us>
@bedevere-bot bedevere-bot mentioned this issue Jun 6, 2023
Merged
terryjreedy pushed a commit that referenced this issue Jun 6, 2023
@miss-islington @chrstphrchvz
[3.12] gh-104411: Update test_getint for Tcl 9.0 (GH-104412) (#105356)
260ba1f 
gh-104411: Update test_getint for Tcl 9.0 (GH-104412)
(cherry picked from commit 2c49c75)

Co-authored-by: Christopher Chavez <chrischavez@gmx.us>
terryjreedy pushed a commit that referenced this issue Jun 6, 2023
@miss-islington @chrstphrchvz
[3.11] gh-104411: Update test_getint for Tcl 9.0 (GH-104412) (#105357)
daf22ca 
gh-104411: Update test_getint for Tcl 9.0 (GH-104412)
(cherry picked from commit 2c49c75)

Co-authored-by: Christopher Chavez <chrischavez@gmx.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-tkinter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@serhiy-storchaka @chrstphrchvz @terryjreedy