Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sysconfig.get_default_scheme versionadded vs versionchanged #100206

Closed
FFY00 opened this issue Dec 13, 2022 · 1 comment
Closed

sysconfig.get_default_scheme versionadded vs versionchanged #100206

FFY00 opened this issue Dec 13, 2022 · 1 comment
Labels
docs Documentation in the Doc dir

Comments

@FFY00
Copy link
Member

FFY00 commented Dec 13, 2022 •
edited by bedevere-bot
Loading

Documentation

get_default_scheme used to be private and called _get_default_scheme, but in GH-24644, it was made public. That PR uses the versionchanged directive to document this, but this is confusing to users, I believe the correct directive should be versionadded.

Linked PRs
@FFY00 FFY00 added the docs Documentation in the Doc dir label Dec 13, 2022
@bedevere-bot bedevere-bot mentioned this issue Dec 13, 2022
Merged
FFY00 added a commit to FFY00/cpython that referenced this issue Dec 13, 2022
@FFY00
pythonGH-100206: use versionadded for the addition of sysconfig.get_d…
aca5303 
…efault_scheme

Signed-off-by: Filipe Laíns <lains@riseup.net>
hugovk pushed a commit that referenced this issue Dec 13, 2022
@FFY00
GH-100206: use versionadded for the addition of sysconfig.get_default…
d3ea82a 
…_scheme (#100207)
This was referenced Dec 13, 2022
Merged
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Dec 13, 2022
@FFY00 @miss-islington
pythonGH-100206: use versionadded for the addition of sysconfig.get_d…
7779344 
…efault_scheme (pythonGH-100207)

(cherry picked from commit d3ea82a)

Co-authored-by: Filipe Laíns <lains@riseup.net>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Dec 13, 2022
@FFY00 @miss-islington
pythonGH-100206: use versionadded for the addition of sysconfig.get_d…
663f6b9 
…efault_scheme (pythonGH-100207)

(cherry picked from commit d3ea82a)

Co-authored-by: Filipe Laíns <lains@riseup.net>
miss-islington added a commit that referenced this issue Dec 13, 2022
@miss-islington @FFY00
GH-100206: use versionadded for the addition of sysconfig.get_default…
cd4166f 
…_scheme (GH-100207)

(cherry picked from commit d3ea82a)

Co-authored-by: Filipe Laíns <lains@riseup.net>
miss-islington added a commit that referenced this issue Dec 13, 2022
@miss-islington @FFY00
GH-100206: use versionadded for the addition of sysconfig.get_default…
f5f68ff 
…_scheme (GH-100207)

(cherry picked from commit d3ea82a)

Co-authored-by: Filipe Laíns <lains@riseup.net>
@hugovk
Copy link
Member

hugovk commented Dec 13, 2022

Merged and backported, thank you!

@hugovk hugovk closed this as completed Dec 13, 2022
carljm added a commit to carljm/cpython that referenced this issue Dec 14, 2022
@carljm
Merge branch 'main' into typedocs
53d33a1 
* main: (103 commits)
  pythongh-100248: Add missing `ssl_shutdown_timeout` parameter in `asyncio` docs (python#100249)
  Assorted minor fixes for specialization stats. (pythonGH-100219)
  pythongh-100176: venv: Remove redundant compat code for Python <= 3.2 (python#100177)
  pythonGH-100222: Redefine _Py_CODEUNIT as a union to clarify structure of code unit. (pythonGH-100223)
  pythongh-99955: undef ERROR and SUCCESS before redefining (fixes sanitizer warning) (python#100215)
  pythonGH-100206: use versionadded for the addition of sysconfig.get_default_scheme (python#100207)
  pythongh-81057: Move _Py_RefTotal to the "Ignored Globals" List (pythongh-100203)
  pythongh-81057: Move Signal-Related Globals to _PyRuntimeState (pythongh-100085)
  pythongh-81057: Move faulthandler Globals to _PyRuntimeState (pythongh-100152)
  pythongh-81057: Move tracemalloc Globals to _PyRuntimeState (pythongh-100151)
  pythonGH-100143: Improve collecting pystats for parts of runs (pythonGH-100144)
  pythongh-99955: standardize return values of functions in compiler's code-gen (python#100010)
  pythongh-79218: Define `MS_WIN64` macro for Mingw-w64 64bit on Windows (pythonGH-100137)
  Fix: typo (Indention) (pythonGH-99904)
  pythongh-96715 Remove redundant NULL check in `profile_trampoline` function (python#96716)
  pythongh-100176: remove incorrect version compatibility check from argument clinic (python#100190)
  clarify the 4300-digit limit on int-str conversion (python#100175)
  pythongh-70393: Clarify mention of "middle" scope (python#98839)
  pythongh-99688: Fix outdated tests in test_unary (python#99712)
  pythongh-100174: [Enum] Correct PowersOfThree example. (pythonGH-100178)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hugovk @FFY00