Skip to content

Make Windows (x64) GitHub action mandatory on master branch #368

Closed
@vstinner

Description

@vstinner

Hi,

Last week, I asked to make Travis CI and Windows (x64) CI mandatory on Python PRs: #365

Problem: on documentation-only PRs, GitHub Action jobs were not run but GitHub still required Windows (x64) job to pass even if it never run.

I worked around the issue in the master branch, by always running GitHub action jobs, even for documentation-only PRs:

Would it be possible to make Windows (x64) mandatory in the master branch?

If it goes well, I will backport the change to 3.7 and 3.8 and then request to also make it mandatory there.

Another PR was also proposed to skip GH Actions jobs for documentation-only changes. Basically, re-do what was done previously, but in a different ways (without "paths-ignored") to workaround a GitHub limitation.

@Mariatta @zooba @brettcannon: Is it ok for you?

Example of recent PR: python/cpython#19982 all jobs are green, great :-) (Windows (x64) helped me to find a real bug in the first version of my PR, thanks!)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions