Skip to content

Uninstall step: set warnOnFailure to True #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 8, 2022

No description provided.

@vstinner
Copy link
Member Author

vstinner commented Nov 8, 2022

Recent example: https://buildbot.python.org/all/#/builders/531/builds/2842

On "s390x Fedora Clang Installed 3.x", the git fetch -f -t https://github.com/python/cpython.git main --progress command failed with:

fatal: unable to access 'https://github.com/python/cpython.git/': The requested URL returned error: 503

The "git" step fails but has warnOnFailure = True. Problem: the "uninstall" also failed because the target/ directory doesn't exist. It marked the whole step as a failure, whereas it's expected that uninstall fails. It's not a bug in Python, just a network issue.

@vstinner vstinner merged commit 1c8901a into main Nov 8, 2022
@vstinner vstinner deleted the uninstall_warning branch November 8, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant