Skip to content

Temporarily remove 3.12 from the python-version list in CI workflow. #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Temporarily remove 3.12 from the python-version list in CI workflow. #350

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a54dbef
Update `python-version` in CI workflow.
ezio-melotti Aug 15, 2023
24a0675
Add `allow-prereleases: true`.
ezio-melotti Aug 15, 2023
475f4c7
Remove `3.12` from the `python-version` list.
ezio-melotti Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ jobs:
strategy:
fail-fast: false
matrix:
# TODO replace 3.12.0-alpha.4 with 3.12-dev when
# aiohttp, frozenlist and yarl support alpha 5+
# TODO: add back 3.12 when the aiohttp issue is fixed, see
# https://github.com/python/blurb_it/pull/330#issuecomment-1449496275
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12.0-alpha.4"]
# and https://github.com/aio-libs/aiohttp/issues/7229
python-version: ["3.8", "3.9", "3.10", "3.11"]

steps:
- uses: actions/checkout@v3
Expand All @@ -24,6 +24,7 @@ jobs:
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
allow-prereleases: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left this here so that we don't forget, but I could also remove it and it to the draft PR that adds 3.12 back if you prefer:

Suggested change
allow-prereleases: true

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to leave it in

cache: pip
cache-dependency-path: |
dev-requirements.txt
Expand Down