Use underscores instead of spaces in paths

[hugovk]

For python/core-workflow#186.

Companion to python/core-workflow#499.

I've not tested this other than running the unit tests.

I think this is all we need for blurb-it? For example, there's already "Tools-Demos" with no "/".

[ezio-melotti]

If I'm reading the code correctly, this value is retrieved here:

blurb_it/blurb_it/__main__.py

Lines 155 to 157 in a346755

	section = data.get("section", "").strip()
	news_entry = data.get("news_entry", "").strip() + "\n"
	path = await util.get_misc_news_filename(issue_number, section, news_entry)

and then used to create the filename in:

blurb_it/blurb_it/util.py

Lines 11 to 15 in a346755

	async def get_misc_news_filename(issue_number, section, body):
	date = time.strftime("%Y-%m-%d-%H-%M-%S", time.localtime())
	nonce = await nonceify(body)
	path = f"Misc/NEWS.d/next/{section}/{date}.gh-issue-{issue_number}.{nonce}.rst"
	return path

There is only a test for this function:

blurb_it/tests/test_util.py

Lines 42 to 46 in a346755

	async def test_get_misc_news_filename():
	path = await util.get_misc_news_filename(
	issue_number=123,
	section="Library",
	body="Lorem ipsum dolor amet flannel squid normcore tbh raclette enim"

The changes look OK to me, even though they don't seem to be covered by the tests. If you think it's worth it, you could add another test for get_misc_news_filename, and possibly update its code to reject sections that include spaces.

[hugovk]

Sure, updated!

[hugovk]

Updated to use underscores instead of hyphens, to match blurb, as decided during the EuroPython sprint: python/core-workflow#499 (comment)

[ezio-melotti]

Is something still blocking this PR?

[hugovk]

Yes, python/core-workflow#499 needs merging first.

[ezio-melotti]

Is something blocking python/core-workflow#499? 🙃

[hugovk]

Someone to hit the big green merge button? I think it's ready.

[hugovk]

I've released blurb 1.2.0 that now uses underscores for the directories:

https://github.com/python/blurb/releases/tag/v1.2.0

Let's give it a little bit of time for testing first, then we can mark this as ready for review/merge.

[hugovk]

Let's give it a little bit of time for testing first, then we can mark this as ready for review/merge.

This is now ready for review/merge.

After it's merged and we've confirmed it's working, I'll post on Discuss to encourage people to upgrade their blurb CLI.

Further down the line, we can add a pre-commit check to prevent creation of dirs with spaces.

[hugovk]

We already have an approval, let's merge! 🚀

[hugovk]

Confirmed working: python/cpython@4ea1895 (#122242) 🚀