Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any way to allow blurb_it to write to other people's pending cpython PRs? #10

Open
gpshead opened this issue Dec 26, 2018 · 3 comments
Open

Comments

@gpshead
Copy link
Member

gpshead commented Dec 26, 2018

I was hoping to use the we blurb_it to write a NEWS entry for someone's PR that currently lacked one while reviewing it. Unfortunately only appear to be able to grant it access to my own cpython fork rather than PR branches in other people's forks.

Obviously I can't grant it blanket write access to everything I have access to so I'm not sure there is anything that can be done about this. I'm just filing the issue to as a 🦄 "wouldn't it be nice if" 🦄 idea.

@Mariatta
Copy link
Member

I'm still investigating on how to make this happen. The problem is that blurb_it as a GitHub App has limited permissions compared to a regular user like you and me, so the app doesn't have the ability to make edits to the pull request. It is returning a 403 error, Resource not accessible by integration. I opened a ticket with GitHub today and asked about this situation, to figure out how to accomplish this.

@Mariatta
Copy link
Member

Response from GitHub support:

GitHub Apps are limited to the repositories they are installed on. While your GitHub App may have permission to update a file in a repository they're installed to, they won't be able to access a fork's file contents if it's not installed on the fork.

So it seems like blurb-it won't be able to do this, not as a GitHub App, but maybe of I use miss-islington's oauth token...

@pablogsal
Copy link
Member

We may be able to use the "Allow edits from maintainers" feature with miss-Islington directly, as she can push to other people branches even without them authenticating in the APP/oauth APP if the checkbox is marked (it is by default).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants